Comments (7)
perfect, thanks! then i guess this issue can be closed?
from webviz-ert.
I looked a bit into it and the warning seems to be coming from the dash testing framework.
Even when using the most basic dash test from dash testing
# 1. imports of your dash app
import dash
from dash import html
# 2. give each testcase a test case ID, and pass the fixture
# dash_duo as a function argument
def test_001_child_with_0(dash_duo):
# 3. define your app inside the test function
app = dash.Dash(__name__)
app.layout = html.Div(id="nully-wrapper", children=0)
# 4. host the app locally in a thread, all dash server configs could be
# passed after the first app argument
dash_duo.start_server(app)
# 5. use wait_for_* if your target element is the result of a callback,
# keep in mind even the initial rendering can trigger callbacks
dash_duo.wait_for_text_to_equal("#nully-wrapper", "0", timeout=4)
# 6. use this form if its present is expected at the action point
assert dash_duo.find_element("#nully-wrapper").text == "0"
# 7. to make the checkpoint more readable, you can describe the
# acceptance criterion as an assert message after the comma.
assert dash_duo.get_logs() == [], "browser console should contain no error"
# 8. visual testing with percy snapshot
dash_duo.percy_snapshot("test_001_child_with_0-layout")
We can reproduce the warning.
Not sure why when running all tests it seems the warning is coming from specific tests, it is not. it comes from all tests if they are ran individually
I think it is a good idea to keep this issue open to just track that this is patched in time or if not to just pin the dash version once Flask 2.3 hits us.
from webviz-ert.
@valentin-krasontovitsch could you as our next release manager just verify / check if this is now solved in dash? I guess it is not very far into the future before we go to flask 2.3 and this will break if not fixed.
from webviz-ert.
fixed in dash 2.7.0 according to changelog
from webviz-ert.
should i specify the min version in webviz-ert's requirements? or should i just make sure that bleeding / my current beta komodo build have a higher version? where do we fix this stuff, locally on the project level or globally in komodo or both, and it depends?
from webviz-ert.
( fyi bleeding has dash 2.7.0 but please still answer the question above if you will ^^ )
from webviz-ert.
I think just bumping in bleeding and your release is sufficient! Usually we try to have as little pinning / restrictions on the project level as possible.
from webviz-ert.
Related Issues (20)
- Integration tests fail if $HOST is set
- Use pytest mark in testkomodo.sh
- Guarantee chromium version for integration test HOT 1
- Fix flaky test on self-hosted runner
- ValueError: no types given, on startup HOT 3
- Reassure user that app is starting
- Update to new storage api
- Use new `urllib.HTTPResponse` API
- Fix flaky selenium tests HOT 1
- webviz-ert: adjust timeout HOT 1
- Incompatible with Pandas==2.0.1
- Integration test fails with new ert storage
- Process to download ChromeDriver is broken
- Simplify chromedriver download in `testkomodo.sh` HOT 1
- Chromedriver unzip fails on Azure
- Mark tests requiring dash / Selenium so they can be turned off HOT 1
- Nightly tests fail to download chromium-driver HOT 6
- Does not build on Python 3.12
- Chrome driver downloads still failing
- bleeding fails with ERROR at setup of test_observation_analyzer_view_ensemble_no_observations HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webviz-ert.