Giter VIP home page Giter VIP logo

Comments (7)

ericdanan avatar ericdanan commented on August 16, 2024 1

Thank you for pointing this out and sorry for the slow reply. I will look into the issue but I am completely out of time at the moment so it may take a couple of weeks before I can get to it.

from counsel-projectile.

ericdanan avatar ericdanan commented on August 16, 2024 1

I see, will try to make it work.

from counsel-projectile.

ericdanan avatar ericdanan commented on August 16, 2024 1

The latest commit introduces a new switching mechanism that should avoid this issue of current buffer being incorrectly listed while still allowing ivy-resume to work. Please let me know if it doesn't.

from counsel-projectile.

ericdanan avatar ericdanan commented on August 16, 2024

I can reproduce the error. The reason is that ivy-resume looks for the buffer counsel-projectile-find-file was called from. But counsel-projectile-switch-project calls counsel-projectile-find-file from a temporary buffer (this is how projectile-switch-project works, not specific to counsel-projectile). So the buffer no longer exists when ivy-resume is called.

It does not seem straightforward to me how to solve this, I will think about it. But is there any advantage of using ivy-resume instead of directly calling counsel-projectile-find-file once again?

from counsel-projectile.

DarthFennec avatar DarthFennec commented on August 16, 2024

In general, I like to use ivy-resume when I already had something typed into the search, and/or I had navigated down the list a decent amount. I'd rather not have to retype/rescroll back to where I was, if I can help it.

For example, if I open a project and do counsel-projectile-ag, enter some text I'm looking for, and scroll to a file that appears to be relevant, I'll open the file. If I then realize that this wasn't the file I was looking for after all, I'd like to use ivy-resume to continue my search from where I left off, without redoing the entire search.

from counsel-projectile.

DarthFennec avatar DarthFennec commented on August 16, 2024

I'm not entirely sure why, but this suddenly appears to work for me now, even though nobody seems to have made any relevant changes recently. Could you verify this?

from counsel-projectile.

ericdanan avatar ericdanan commented on August 16, 2024

I think this is because of recent change in the function projectile-switch-project-by-name. This change has other effects, eg if you in a project buffer and switch to another project you should see this buffer incorrectly listed in the project you switched to. There is also a recent issue raised in the projectile repo that is perhaps related. I'd have to take some time to look into this.

from counsel-projectile.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.