Giter VIP home page Giter VIP logo

Comments (8)

gumarm avatar gumarm commented on August 24, 2024 1

@Burgi0101 It should at least be compatible with Windows according to Node's documentation: https://nodejs.org/api/path.html

@ericelliott I'll search around if I can find a reason as to why it doesn't work, if I don't find anything I'll send a PR for the workaround!

Thanks for your time guys!

from react-pure-component-starter.

ericelliott avatar ericelliott commented on August 24, 2024

Did you remember to run npm install?

from react-pure-component-starter.

ongerit avatar ongerit commented on August 24, 2024

I ran npm install but still getting this issue.

from react-pure-component-starter.

gumarm avatar gumarm commented on August 24, 2024

Same for me, packages were installed and everything worked once I replaced the include line in the webpack config.

from react-pure-component-starter.

higgins1b avatar higgins1b commented on August 24, 2024

I ran into the same issue. Thank you @gumarm for adding your workaround.

I too am curious as to what could be causing this.

As a reference, here is the loaders block from my webpack.config.dev.js:

loaders: [{
  test: /\.js$/,
  loader: 'babel-loader',
  exclude: /node_modules/,
  query: {
    presets: ['es2015', 'stage-0', 'react']
  }
}]

I am on a windows machine, node v7.6.0, npm v4.1.2

Thank you Eric for all you do in the tech community!

from react-pure-component-starter.

gumarm avatar gumarm commented on August 24, 2024

@higgins1b You can also replace include: path.join(__dirname, 'source') with an include on the hard-coded path like include: 'path_here'. I've had this issue with using path.join on Windows machines before.

from react-pure-component-starter.

ericelliott avatar ericelliott commented on August 24, 2024

I'm open to a PR replacing path.join with an exclude of node_modules, but I'm curious about why path.join doesn't work on Windows. Have any of you searched the Node repo for a corresponding issue and possible resolutions?

from react-pure-component-starter.

Burgi0101 avatar Burgi0101 commented on August 24, 2024

Are we sure that the path module is cross platform compatible?

from react-pure-component-starter.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.