JS9.ChangeRegions() to change position incorrect after zooming image about js9 HOT 5 CLOSED

I'm having some trouble reproducing this, which doesn't mean there isn't a bug. Simple tests all seems to work, as does zooming in/out using the < and > keys and then calling ChangeRegions:

So I'm missing something ... can I get a copy of the FITS file you are using (since this problem might be FITS wcs-dependent) as well as the position changes you are making? I just need to reproduce it and we can get it fixed.

from js9.

Wait, wait, I made it happen once .... let me continue, I should have enough to go one ...

from js9.

My experiments indicate that this happens only when the region being moved is selected. There is some special code in ChangeRegions() that deals with selected regions. It was valid for Fabric.js 3.x, but perhaps is no longer valid for Fabric.js 4.x (as does happen). I'll look into this. Nice bug, thanks!

from js9.

OK, this should be fixed. New code is updated in GitHub. There actually was a common problem in Set{Pan,Zoom,Flip}: after doing these operations, it's unclear how to update the selection completely, so your inspired suggestion to fully regenerate the selection was what I eventually used (though in another part of the JS9 code). If it works for you too, feel free to close this issue.

from js9.

Yes, that's fixed it - thanks very much!

from js9.