Comments (2)
I don't agree with the idea of fitting a RandomForest by selecting the best features from a random subset at each node of a given tree, or at least I didn't understand it. I've just reviewed the code and it seems to behave as correct as I know, and actually it doesn't reuse DecisionTrees as you said so I don't get the problem with the behavior:
- Here the decision trees are initialized separately by getting instances of the class
ClassificationTree
and storing them into a list (as in any OOP program, objects are not the same than classes). Therefore, the RF doesn't use the same tree for predictions. - Here occurs the sample of feature for each tree, by getting indexes of the whole set of features and fitting the given tree with the selection of those features. Therefore, every tree is fitted with a random selection of features in a separate way.
Let me know the algorithm that you wanted to explain (through a link or a paper citation) to compare the implementations, but so far I think this implementation is correct. In addition, I also congrats for the whole repository, it's great to have a prolix set of implementation of the most important algorithms handled in ML.
from ml-from-scratch.
Both implementations are correct. Erik is using the original feature subset selection procedure proposed by Tin Kam Ho whereas I am refering to the one used by Leo Breiman.
In 1995 Tin Kam Ho published his paper "random decision forests" using a randomly selected subset of features for growing each tree. However in 2001, Leo Breiman published his seminal Random Forests paper, wherein the feature subset is randomly selected at each node within each tree, not at each tree. While Breiman cited Ho, he did not specifically explain the move from tree-level to node-level random feature selection.
Almost all implementations I've seen use the Breiman feature selection at node level instead of tree level. I.E. Elements of Statistical Learning Page 588, https://web.stanford.edu/~hastie/Papers/ESLII.pdf and Sklearn's RandomForestClassifier, https://scikit-learn.org/stable/modules/generated/sklearn.ensemble.RandomForestClassifier.html
from ml-from-scratch.
Related Issues (20)
- Project dependencies may have API risk issues
- Nestrov Accelerated Gradient Descent HOT 1
- Linear Regression Regularization bias HOT 1
- (A doubt NOT an issue) Gradient of loss function having different sign after performing first-degree differentiation of LogisticLoss
- Naive Bayes
- python setup.py install does not work on Windows 10
- Missing number of neurons in grad_w for dense layer
- Error in MLP HOT 1
- BN layer and dropout
- why LassoRegression need X = normalize(polynomial_features(X, degree=self.degree)) code in LassoRegression class?
- Implementations
- ModuleNotFoundError: No module named 'mlfromscratch'
- Linear Discriminant Analysis HOT 1
- TypeError: make_blobs() got an unexpected keyword argument 'n_smaples'
- Adam mhat and vhat updates
- can you add code for intercept /bias to regressions HOT 1
- How to save the model? HOT 2
- No lambda, gamma for XGBoostRegressionTree?
- cross entropy is correct? HOT 2
- ML from scratch HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ml-from-scratch.