Issue with RTL (iOS 9.x) (The indicator resizes to the tab Before next not after and More) ... about carbonkit HOT 12 CLOSED

Also notice something for iOS with LTR, everything is flipped from LTR to RTL but the actually X-Axis still measures from 0 (on the far left) to the max on (the far right),
for example of set text to align left, it'll align right, if you set constraint left: 10 pt, it'll be constraint right 10 pt.
but if you measure the position of item standing at the far left, it'll be 0, while on the right it'll be something like 300...

I'm not expert, but I thought that info might help, will also try to debug the code locally and see what's happening exactly.

And btw: your lib. is AWESOME (I will stick with it for my app, even if it have bugs or whatever :D)

from carbonkit.

Notice: this issue Affects iOS 9 only, in iOS 8 the library is always displayed LTR

from carbonkit.

hey @shehabic
please can you post any screenshot? I will see this issues asap

from carbonkit.

I will upload a video shortly and share the link here

from carbonkit.

@ermalkaleci here it is: https://www.youtube.com/watch?v=7YqM54Z2fDU

from carbonkit.

I added this small piece of code to help me understand what's happening with RTL on ios 9+ :

        bool RTL = [UIApplication sharedApplication].userInterfaceLayoutDirection == UIUserInterfaceLayoutDirectionRightToLeft;       
        NSLog(@"offsetX: %f, SegmentWidth: %f, ScrollViewWidth: %f", offset.x, segmentedWidth, scrollViewWidth);
        NSLog(@"is Right to left: %@", RTL ? @"yes" : @"no");

around here:
https://github.com/ermalkaleci/CarbonKit/blob/master/CarbonKit/CarbonTabSwipeNavigation.m#L308

The issue I found is a bit complicated, the indexes of tabs are somehow flipped on RTL, also the condition of ScrollX vs Width is flipped, but only on iOS 9, so I found that the hack I did was a bit messy and doesn't qualify enough to be a quality PR.

from carbonkit.

@shehabic so on iOS 8, it works fine?

from carbonkit.

Yes because the lib is displayed LTR on iOS 8
But if you use the condition above, RTL will be true, though the lib is showing LTR but the rest of the UI is RTL

from carbonkit.

I think I fixed it

from carbonkit.

@shehabic can you try and let me know?
add this to your Podfile

pod 'CarbonKit', :git => 'https://github.com/ermalkaleci/CarbonKit.git', :commit => 'ae5830e'

pod update CarbonKit

from carbonkit.

👍 works perfectly, thanks, and keep up the great work, I think this lib. definitely deserves more Stars.

from carbonkit.

@shehabic I am deploying version 2.1.1
Make sure to update podfile

from carbonkit.