Comments (4)
erzki
commented on July 27, 2024
Hi
Nice catch. Can you create a pull request?
Den ons 14 okt. 2020 02:20itsthetaste <[email protected]> skrev:
… Hi,
Thanks for the lib, been using it for years, just stumbled across this
issue though.
In your jquery shim, your only dealing with the options.data.data needed
for the send message.
but the poll message also needs messageId and groupsToken parameters.
Without the messageId, I was noticing missing messages.
For me this fixed the missing messages, I didn't bother with the
groupsToken as I don't use them.
var dataToSend = options.data.data ? `data=${encodeURIComponent(options.data.data)}` : options.data.messageId ? `messageId=${options.data.messageId}` : '';
request.send(dataToSend);
the poll should look like this;
[image: image]
<https://user-images.githubusercontent.com/4565648/95929140-30944180-0dbb-11eb-8344-449f900557af.png>
Thanks
Rich
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMIMEKRAS36L4RRHPBY7R3SKTVEZANCNFSM4SP4XHIQ>
.
from signalr-asp-net.
itsthetaste
commented on July 27, 2024
yeh, i'll sort one out
from signalr-asp-net.
itsthetaste
commented on July 27, 2024
Hi,
I've tried making a branch and push changes to it, but I don't have permission to make changes.
remote: Permission to erzki/signalr-asp-net.git denied to itsthetaste.
the revised fix (to also handle the groupsToken) and whatever else might be added in the future is.
const formData = Object.keys(options.data)
.map(key => `${encodeURIComponent(key)}=${encodeURIComponent(options.data[key])}`)
.join('&');
request.send(formData);
Thanks
Rich
from signalr-asp-net.
erzki
commented on July 27, 2024
@itsthetaste Late answer but if you fork this repo and do some change, then you can create a pull request from that fork to this repo https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork
from signalr-asp-net.
Related Issues (2)
- Add types package HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from signalr-asp-net.