Comments (8)
philipkershaw
commented on July 20, 2024
This is hard-wiring it for no SSL auth - not a good idea. How about making verify a configurable parameter so that callers can choose.
Config setting -
ca_dir = '/path/to/certfile'
Then,
requests.get('https://github.com', verify=ca_dir)
from esgf-pyclient.
cehbrecht
commented on July 20, 2024
Maybe add the verify option as parameter and pass it to requests?
def logon_with_openid(openid, ssl_verify=True):
...
requests.get('https://github.com', verify=ssl_verify)
... and mention in the parameter description how to configure it in case of ssl verification errros.
from esgf-pyclient.
pchengi
commented on July 20, 2024
Bad idea. The default should be always to check. Optionally turning off
checks should be ok.
/Prashanth.
…On Wed, Feb 1, 2017 at 12:55 PM, MacPingu ***@***.***> wrote:
Maybe add the verify option as parameter and pass it to requests?
def logon_with_openid(openid, ssl_verify=True):
...
requests.get('https://github.com', verify=ssl_verify)
... and mention in the parameter description how to configure it in case
of ssl verification errros.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADb9o0dVGsYpOPC4oJ_gweMTsOhhcfuOks5rYHKZgaJpZM4Lyjem>
.
from esgf-pyclient.
maheshguru
commented on July 20, 2024
Better to set SSL verify true as default and also it is recommended.
I agree with Prashanth
/Mahesh
…On Wed, Feb 1, 2017 at 5:34 PM, pchengi ***@***.***> wrote:
Bad idea. The default should be always to check. Optionally turning off
checks should be ok.
/Prashanth.
On Wed, Feb 1, 2017 at 12:55 PM, MacPingu ***@***.***>
wrote:
> Maybe add the verify option as parameter and pass it to requests?
>
> def logon_with_openid(openid, ssl_verify=True):
> ...
> requests.get('https://github.com', verify=ssl_verify)
>
> ... and mention in the parameter description how to configure it in case
> of ssl verification errros.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#16 (comment)
>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ADb9o0dVGsYpOPC4oJ_
gweMTsOhhcfuOks5rYHKZgaJpZM4Lyjem>
> .
>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUi7PdV_pMfJTkQo1vGG-9VPkSeTIEOXks5rYHTggaJpZM4Lyjem>
.
--
Best Regards,
R.Mahesh
*Known is a drop, Unknown is an ocean*
from esgf-pyclient.
pchengi
commented on July 20, 2024
I replied in haste. I guess Carsten meant keeping verify as true by
default, while giving an option to pass verify=false. Sure, that sounds
reasonable.
/Prashanth
…On Wed, Feb 1, 2017 at 1:13 PM, Mahesh ***@***.***> wrote:
Better to set SSL verify true as default and also it is recommended.
I agree with Prashanth
/Mahesh
On Wed, Feb 1, 2017 at 5:34 PM, pchengi ***@***.***> wrote:
> Bad idea. The default should be always to check. Optionally turning off
> checks should be ok.
>
> /Prashanth.
>
> On Wed, Feb 1, 2017 at 12:55 PM, MacPingu ***@***.***>
> wrote:
>
> > Maybe add the verify option as parameter and pass it to requests?
> >
> > def logon_with_openid(openid, ssl_verify=True):
> > ...
> > requests.get('https://github.com', verify=ssl_verify)
> >
> > ... and mention in the parameter description how to configure it in
case
> > of ssl verification errros.
> >
> > —
> > You are receiving this because you are subscribed to this thread.
> > Reply to this email directly, view it on GitHub
> > <#16#
issuecomment-276639554
> >,
> > or mute the thread
> > <https://github.com/notifications/unsubscribe-auth/ADb9o0dVGsYpOPC4oJ_
> gweMTsOhhcfuOks5rYHKZgaJpZM4Lyjem>
>
> > .
> >
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#16 (comment)
>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AUi7PdV_pMfJTkQo1vGG-
9VPkSeTIEOXks5rYHTggaJpZM4Lyjem>
> .
>
--
Best Regards,
R.Mahesh
*Known is a drop, Unknown is an ocean*
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADb9ozGGDl-CotDHkWXwW3e0N09wdAtIks5rYHbagaJpZM4Lyjem>
.
from esgf-pyclient.
cehbrecht
commented on July 20, 2024
I guess Carsten meant keeping verify as true by default, while giving an option to pass verify=false. Sure, that sounds reasonable.
Yes, it was meant as you said. Just need a chance to configure it :)
from esgf-pyclient.
agstephens
commented on July 20, 2024
Hi folks, I have merged in PR #14. If any of you guys that understand the details of this Issue have time it would be brilliant if you can make the change and then I'll test and deploy. Thanks, Ag
from esgf-pyclient.
agstephens
commented on July 20, 2024
I believe this works - so closing.
from esgf-pyclient.
Related Issues (20)
- Failing CI build: parsing of HTTPResponse by defusedxml.ElementTree HOT 1
- Is there a way to search the entire ESGF? HOT 4
- `ignore_facet_check` search option appears to be broken
- Dependency problem (version mismatch between pyesgf and requests library) leading to AttributeError: module 'requests_cache' has no attribute 'core' HOT 5
- add "facets" keyword argument to DatasetResult.file_context
- New release? HOT 5
- Import trial of `MyProxyClient` in `pyesgf/logon.py` outputs misleading error and incompatibility with `cryptography` from Anaconda `main` channel HOT 2
- logon for http request HOT 2
- lm.logon timeout HOT 12
- Facets warning with aggregation_context(): unexpected keyword
- CMIP6 data availability? HOT 2
- logon does not allow access to all ESGF nodes HOT 13
- Unexpected number of results for large query
- Not matching all the expected files HOT 4
- logon refused from my laptop HOT 3
- Facets warning appears even when facets are specified HOT 5
- collection import errors from python 3.10 HOT 1
- [via MyProxyClient] Import of `MyProxyClient` fails due to complete retirement of `SafeConfigParser` in Python 3.12 HOT 2
- Fix `tests/test_results` test module
- 503 HTTPErrors should not be failing the tests
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from esgf-pyclient.