Feature proposal: no-double-resolve. Warn against resolving a promise twice, or execution after resolve. about eslint-plugin-promise HOT 4 CLOSED

That's very similar to this rule:
https://eslint.org/docs/rules/callback-return

Which I support

from eslint-plugin-promise.

Thanks @xjamundx, I'll check that out, it looks promising!

from eslint-plugin-promise.

I ran a test with some existing code using https://eslint.org/docs/rules/callback-return which did highlight a location where I was calling a callback without a return, but in that case this was correct behaviour.

As for my promise example, I've created an example https://github.com/mrthehud/eslint-plugin-promise-issue-222/blob/master/src/foo.ts, but this doesn't warn against my double calling of resolve unfortunately.

I think there may be scope here, I guess I'd want to start by adding some test cases to https://github.com/mysticatea/eslint-plugin-node/blob/master/tests/lib/rules/callback-return.js to reprodue.

from eslint-plugin-promise.

🎉 This issue has been resolved in version 6.1.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

from eslint-plugin-promise.