Comments (3)
@simonratner this rule only enforces things explicitly inside the then()
and catch()
block, so I'm thinking yield
won't really apply in those situations? Let me know if you have some example that might cause an issue.
from eslint-plugin-promise.
Looks like it currently works as-is, as the expression:
yield getResult().then()
is classified as a YieldExpression
rather than a CallExpression
, so the rule doesn't match, presumably for the same reason why return
doesn't match. I was going purely off the docs, which I guess could use more precision:
Ensure that each time a then() is applied to a promise, a catch() is applied as well.
Exceptions are made if you are returning that promise.
Feel free to close.
from eslint-plugin-promise.
So it looks like this works by accident, but could probably use some tests @simonratner any chance you can submit a PR with a few test cases?
from eslint-plugin-promise.
Related Issues (20)
- > @xjamundx what can we do to help to get this merged? HOT 1
- > @xjamundx what can we do to help to get this merged? HOT 1
- > > @xjamundx what can we do to help to get this merged? HOT 1
- No tag for v5.2.0 HOT 5
- prefer-await-to-then doesn't enforce .then/.catch/.finally HOT 2
- Invitation to move to official `eslint-community` org
- Consider automatic releases HOT 1
- Add support for Promise.allSettled() and Promise.any() HOT 1
- `no-multiple-resolved` wrongly reports `reject` in try/catch block HOT 6
- .github/workflows/CI.yml
- `promise/prefer-await-to-then` ignore constructor scope HOT 1
- Rule to require that Promise executor function calls resolve
- `no-multiple-resolved` wrongly reports `reject` in try/catch block
- False positive of `isInsideCallback` for functions with first arg named `err`/`error`
- does it support typescript?
- New Rule: Prefer `Promise.resolve(foo)` to `new Promise((resolve) => resolve(foo))`
- Support ESLint 9 and Flat config HOT 13
- apromise/catch-or-return will cause many empty callback of match
- `promise/always-return` should not be reported when process exits HOT 1
- `always-return`: enable `ignoreLastCallback` by default
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-plugin-promise.