Giter VIP home page Giter VIP logo

Comments (3)

xjamundx avatar xjamundx commented on May 18, 2024

@simonratner this rule only enforces things explicitly inside the then() and catch() block, so I'm thinking yield won't really apply in those situations? Let me know if you have some example that might cause an issue.

from eslint-plugin-promise.

simonratner avatar simonratner commented on May 18, 2024

Looks like it currently works as-is, as the expression:

yield getResult().then()

is classified as a YieldExpression rather than a CallExpression, so the rule doesn't match, presumably for the same reason why return doesn't match. I was going purely off the docs, which I guess could use more precision:

Ensure that each time a then() is applied to a promise, a catch() is applied as well. 
Exceptions are made if you are returning that promise.

Feel free to close.

from eslint-plugin-promise.

xjamundx avatar xjamundx commented on May 18, 2024

So it looks like this works by accident, but could probably use some tests @simonratner any chance you can submit a PR with a few test cases?

from eslint-plugin-promise.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.