Giter VIP home page Giter VIP logo

Comments (8)

gyandeeps avatar gyandeeps commented on June 9, 2024

I like it. Its so handy when I want to share it with people.

from archive-website.

ilyavolodin avatar ilyavolodin commented on June 9, 2024

Yes, it's on my todo list. It's just not that simple, because rule configuration matters a lot. And we have a lot of rules and options. I don't think it all will fit on query string, so we probably need to get a database to store configuration + code and output a token.
I was planning on addressing it after v1.0.0 releases and I will find time to do a full re-write of the demo.

from archive-website.

nzakas avatar nzakas commented on June 9, 2024

Eek, I really wanted to keep the site static for simplicity - otherwise we will be spending time debugging why the DB connection is slow, broken, etc.

from archive-website.

ilyavolodin avatar ilyavolodin commented on June 9, 2024

from archive-website.

nzakas avatar nzakas commented on June 9, 2024

Yup, that's what I was referring to...why introduce something that could break? The demo isn't really meant to be anything more than just that, a demo to try it out. I think doing anything more than the query string solution is a lot of work for very little gain and maintenance headaches.

from archive-website.

ilyavolodin avatar ilyavolodin commented on June 9, 2024

My idea for this change was to turn demo into a bug reporting tool as well. It would be much easier and quicker to ask people to reproduce their issue in the demo, and past URL into github issue, then chase them for version of ESLint, .eslintrc and error messages that they are seeing.
I originally hoped to find some free service that just allows arbitrary key-value pair storage and retrieval, but I couldn't find anything out there that does this.

from archive-website.

guerrero avatar guerrero commented on June 9, 2024

I think that it can be easy to implement this functionality with JavaScript, due that Jekyll is a static site generator there's no other way to achieve it. We can use a library like URI.js or use plain vanilla JavaScript and window.location.href. But the steps are basically the same:

To share a link:

  • Iterate over the rules to check which of them are active and store them in a dictionary
  • Get the content of the editor and store it in another variable
  • Convert them to an URL query using a library
  • Optionally we can add an eventListener to update the website when the editor content or a rule changes but I think that it wouldn't be a good idea

To get info from a URL query:

  • Parse the query and to the inverse process but checking before if a rule exists and if that's not the case append all the errors to a notification panel that can be placed above the editor

Ok, I'm sure that it wouldn't be as easy as it seems but I can try to implement it if no one is working on this, it will took me more than week but I want to try to achieve it.

from archive-website.

vitorbal avatar vitorbal commented on June 9, 2024

@guerrero the new version of the demo which is react-based is now live, so if you're still interested on implementing the "load from URL" feature, i'd say go for it!

from archive-website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.