Giter VIP home page Giter VIP logo

Comments (4)

theigl avatar theigl commented on July 19, 2024

It instructs the user to run the Kryo benchmarks using a run.sh shell script. The script fails (see below).

I just reviewed the readme for the benchmarks module. Where does it recommend running via run.sh?

It refers to JMH parameters but does not explain where to find explanations for them, or which of them are useful for Kryo.

The readme suggests reasonable defaults for the parameters and explains how to get a full list of parameters. What else do you need?

from kryo.

toolforger avatar toolforger commented on July 19, 2024
  • You're right, I just double-checked: Nothing recommends using run.sh.
  • I'm not 100% sure why I was so focused on run.sh. I think I was trying to make sense of that, and since it is undocumented in what it does and its purpose, I got even more confused because I was looking for the wrong kind of information in README.md (if that makes any sense to you).
  • There's one bit in the README that is unhelpful: The "digging through the JMH code" link. It is failing with "504 Gateway Time-out", and I recall it didn't work for me, either.

I guess I just lost track all the leads and got sidetracked chasing the dead ends, so nothing made sense to me because I was focusing on those parts that were dead ends.
I think that's what's happening a lot when you're new to a project, and you get overwhelmed by information because you do not yet have an intuition for what information is important for the task at hand and what isn't.

Actually I'm running benchmarks just fine now, it has started to "click".
The only thing that I'm missing is a documentation how the benchmark graphs in the release are done, as I'll want that to quickly check whether I damaged performance or not.

from kryo.

NathanSweet avatar NathanSweet commented on July 19, 2024

JMH is a bit of a pain to setup because it generates classes.

from kryo.

toolforger avatar toolforger commented on July 19, 2024

Answering to @NathanSweet, just for the record:

JMH is a bit of a pain to setup because it generates classes.

If it's a pain, then not due to class generation. Not anymore.
The final pieces fell into place maybe two years ago, when IDEs got full annotation processor integration, including the ability to configure their own incremental build machinery from a Maven or Gradle build.

from kryo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.