Warnings with Java 9 about reflectasm HOT 15 OPEN

I'm running into this too, any idea of when a fix may be available.

from reflectasm.

I'm not sure, I haven't looked into it. It's not a problem yet though, it's just a warning. It won't be a problem until they disallow what the library needs to function. At that time we either fix it or the library won't work on the latest JVMs. That is the case for a great many libraries.

from reflectasm.

An option might be to create a multi release jar (aka MRJAR) and use a different way for Java 9+ to defineClass (MethodHandles.Lookup.defineClass).

from reflectasm.

try this:

// suppress "An illegal reflective access operation has occurred" in JDK9+
if (!System.getProperty("java.version").startsWith("1.") && !MethodAccess.class.getModule().isNamed())
Class.class.getModule().addOpens(Class.class.getPackageName(), MethodAccess.class.getModule());

from reflectasm.

In a similar vein to EsotericSoftware/kryo#626, could you support a System property (-Dreflectasm.unsafe=false) or something so that we can stop this error message from appearing (and ideally start to get ready for when illegal access is removed)? 🙏

from reflectasm.

Can ignore or disable the warning.

from reflectasm.

I tried to implement the suggestion of using MethodHandles.lookup().defineClass() instead of ClassLoader.defineClass(), but only got as far as robinverduijn/reflectasm@fix-code-warnings...robinverduijn:fix-illegal-reflective-access. It left me with the warning gone but two tests failing. At that point I got stuck, but maybe someone else can figure out how to make it work from there?

from reflectasm.

@NathanSweet For what it's worth, @magro explained how to fix this problem. Simply replace ClassLoader.defineClass with MethodHandles.Lookup.defineClass

from reflectasm.

Just FYI: still the same warning with java 13

from reflectasm.

Some of my users are also seeing this. See rarcher/couch-potato-server#27 for a discussion.

from reflectasm.

Any update?

from reflectasm.

@NathanSweet Obviously. But can't the underlying problem be fixed?

from reflectasm.

If that works, great! I just haven't had the time or personal need to dig into it.

from reflectasm.

Any news on this?

from reflectasm.

Sorry I'm too busy with other things, but maybe someone could come up with a PR for multi-release jar?

from reflectasm.