Not checking for ESP_FAIL in AsyncCanDriver::transmit about esp-idf-hal HOT 5 CLOSED

Yes I'll patch the driver shortly.

from esp-idf-hal.

No idea without digging (again) into the ESP IDF C source code of the TWAI driver...

from esp-idf-hal.

@leonardodanelutti The way I read the code (I might be wrong) is that ESP_FAIL would only be returned if you are creating the driver without a TX queue (i.e. tx_queue_len == 0)

Can you confirm if you are doing that?

from esp-idf-hal.

@ivmarkov I actually didn't get that error, I was looking at the async implementation for the CanDriver and it seemed strange that the ESP_FAIL error wasn't also checked. Yes, I think you are right, as it is also written in the documentation, ESP_FAIL is returned only if the TX queue is disabled and another message is transmitting at that moment. When that error occurs, I don't think the function should return, right?

from esp-idf-hal.

f958b77

from esp-idf-hal.