Extract ODU HVAC sensors to a separate file about esphome-econet HOT 8 CLOSED

# file: econet_hvac.yaml
# files: [econet_hvac.yaml, econet_hvac_odu.yaml]

Should this be in the HVAC file? Or in the readme?

When we say include do users need to do this manually or they literally put include: econet_hvac_odu.yaml in their econet_hvac.yaml file somewhere?

from esphome-econet.

In each example we have

from esphome-econet.

I assume ODU stands for Outdoors Unit? You can have one line comment: # Use this if you have a communicating outdoors unit (ODU)

from esphome-econet.

Is this how the file itself should look?
Especially because econet_hvac.yaml would already be included?

Also not sure on what icons/device class to use for most of these sensors.

https://github.com/Daniel-dev22/esphome-econet-main/blob/update_hvac_yaml/econet_hvac_odu.yaml

I also updated the hvac.yaml
https://github.com/Daniel-dev22/esphome-econet-main/blob/update_hvac_yaml/econet_hvac.yaml

from esphome-econet.

Look good. But you should first send a PR where you just move sensors from one file to the other. And once merged, send a new PR that adds all the new sensors.

from esphome-econet.

Look good. But you should first send a PR where you just move sensors from one file to the other. And once merged, send a new PR that adds all the new sensors.

Yep I can do that today/tonight EST.

I will add the IDs as well in the second or if that works? Or make that a third pr.

from esphome-econet.

Adding the IDs in the second PR sounds good. Keeping the first PR simple by just moving sensors around will make the diff of the 2nd PR easier to track what was changed.

from esphome-econet.

Addressed in #153

from esphome-econet.