Show error icon for Basemaps that we know will not work. about arcgis-maps-sdk-swift-toolkit HOT 10 CLOSED

How about this? I can't get the exclamation mark to move up and to the right of the thumbnail without making the thumbnail smaller, as the icon is right at the top/trailing edge of the list. Any higher and it gets clipped.

And rounded rects.

from arcgis-maps-sdk-swift-toolkit.

We have a a few Basemaps hard-coded that we know will fail. The user should rarely see this in practice as most maps are WM

from arcgis-maps-sdk-swift-toolkit.

I have a branch that does that here. It needs to be fixed so the icon isn't cut off.

from arcgis-maps-sdk-swift-toolkit.

I like this idea as well. The thumbnail fills the space it's given, so there are three ways to get it to work:

1.) Move the icon inside the bounds of the thumbnail

2.) Shrink the thumbnail if there's an error to provide room for the icon

3.) Always shrink the thumbnails so they are all consistent, whether there's an error or not

Thoughts?

from arcgis-maps-sdk-swift-toolkit.

cc: @dfeinzimer

from arcgis-maps-sdk-swift-toolkit.

I like 1. Another idea: what about putting the exclamation mark at the center of the thumbnail? Did a quick look up in HIG but didn't find anything related.

from arcgis-maps-sdk-swift-toolkit.

I was drawing inspiration from this:

I like option 1 or 3. Maybe option 3 a bit more. Maybe option 3 but reduce the space a bit between the thumbnails. Also did we consider rounding the thumbnail corners?

from arcgis-maps-sdk-swift-toolkit.

At first I liked option 2 better because I felt the larger tiles preserved more details in the previews but now I think the consistent sizing in option 3 looks better.

I might be misremembering but didn't we remove the red we had before in PR 39 because Eric suggested it may be too distracting?

from arcgis-maps-sdk-swift-toolkit.

That's right, we did have something similar. Sorry, I forgot about that. I do think the right sizing of this element is important if we choose to go with it. I think smaller and we can get an idea by how iOS uses it. Looking how it is used in the iOS home screen, the size the icon takes up is not part of the size of the button. It is eating into the space between the buttons. That's important for getting the spacing and sizing right.

from arcgis-maps-sdk-swift-toolkit.

I like it

from arcgis-maps-sdk-swift-toolkit.