Comments (4)
mhdostal
commented on June 21, 2024
1
I had initially intended them to be public, as helpers to clients, like in BasemapGalleryExampleView. If the consensus is that they should be internal to the Toolkit, that's OK with me.
@yo1995 Would having a public toolkitDefault EdgeInsets "preset" or an esriBorder view modifier be helpful in the Samples?
from arcgis-maps-sdk-swift-toolkit.
yo1995
commented on June 21, 2024
1
Honestly speaking I don't have a preference. I think it would be great if esriBorder can be internalized, so the call becomes
BasemapGallery(geoModel: map, items: basemaps)
.style(.automatic())
.padding()from arcgis-maps-sdk-swift-toolkit.
rolson
commented on June 21, 2024
1
internal makes sense
from arcgis-maps-sdk-swift-toolkit.
dfeinzimer
commented on June 21, 2024
Closing for now. As @mhdostal clarified above, the original intent was for them to be public. Since opening this ticket, they're also now in use in PopupExampleView which demonstrates the continued usefulness of a public modifier such as this one.
from arcgis-maps-sdk-swift-toolkit.
Related Issues (20)
- Authenticator UX feedback
- Consider providing localized `Strings` as `Text`
- Synchronize Bundle IDs HOT 3
- AsyncImageView improvements
- Prepare for `NavigationView` deprecation
- Scalebar text is not localized HOT 1
- `FloorFilter` - Fallback to `FloorLevel.levelNumber`
- `FloatingPanel` - Conditionally respect device bottom safe area HOT 4
- Bookmarks menu does not show on Mac Catalyst
- Add spacing for Floating Panel on Mac Catalyst HOT 3
- Fix `BasemapGalleryItemTests.testInit()` failure HOT 1
- Bookmarks list row label is only selectable
- Localized string constants are stored when they should be computed HOT 1
- Fix `DisclosureGroup` trailing padding on iOS HOT 1
- Change layout of `UtilityNetworkTrace.cancelAddStartingPoints` button
- `Bookmarks` - Support automatic refresh
- `200.4` Changes/Additions HOT 1
- `Popup` - Fix formatting for local items HOT 4
- Don't display error message in AsyncImageView HOT 1
- `FloatingPanel` - Content without container is troublesome
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from arcgis-maps-sdk-swift-toolkit.