Resolve minor UI inconsistencies between UWP and WPF about data-collection-dotnet HOT 7 CLOSED

@mikewilburn PR #60 opened

from data-collection-dotnet.

Looks good! Just a few questions for clarification on what I should be seeing:

• did you remove the 'Collapse' button? I'm not seeing it any longer.
• neither the 'Show Detail' nor 'Add Related Record' button shows hovers emphasis. Should they?
• the 'Close' button shows emphasis, but it's gray and not orange like the others. Was this an oversight or intentional?

from data-collection-dotnet.

I did remove the collapse button - the feature didn't really make sense and isn't in the WPF version. It also caused a crash on some devices.

There is a subtle emphasis on the show detail and add record buttons. I don't know if it would look good with the orange hover emphasis, but I can add it if that's what we want.

I'm wondering if we might want to remove the orange hover emphasis altogether. It seems to be suppressing the built-in reveal style.

from data-collection-dotnet.

Totally good with the collapse button removal. Your reasoning makes sense to me. Just wanted to make sure it was a conscious decision and not an unintended result of another change!

As for the hover emphasis, I think the most important thing above all is that we're consistent. If you're unsure whether the current orange looks right and/or think it distracts from what's recommended, then maybe we should remove it and revert back to that built-in style. I think you have good judgement so I'm cool with that!

P.S.

the built-in reveal style

Thanks for sharing that! I had no idea what that was.

from data-collection-dotnet.

Next steps: remove orange hover emphasis; should take a few hours at most.

from data-collection-dotnet.

PR open: #67

from data-collection-dotnet.

PR #67 resolves these behaviors on UWP:

• hover emphasis color is consistent throughout
• tooltips appear for all the buttons
• title is white on green

from data-collection-dotnet.