Update peerDependency esri-leaflet ^2.3.0 to >2.3.0? about esri-leaflet-vector HOT 4 CLOSED

I have not noticed any issues myself, but seems like a reasonable suggestion to me. If possible, do you have replication steps that would show the issue?

from esri-leaflet-vector.

I created a blank folder, cd into that folder, and initialize an npm package with npm init -y. Then install npm i leaflet esri-leaflet. After that, I npm i esri-leaflet-vector. I get the peerDependency warning:

npm WARN [email protected] requires a peer of esri-leaflet@^2.3.0 but none is installed. You must install peer dependencies yourself.

I guess its a minor issue, but making that change from ^ to > would get rid of that warning, which might be confusing considering this plugin works with esri-leaflet v3.

from esri-leaflet-vector.

We are running into a similar issue with esri-leaflet-geocoder here: Esri/esri-leaflet-geocoder#272

I plan to change the peerDependencies to "esri-leaflet": ">2.3.0", like you advise, but similar to the esri-leaflet-geocoder we will also update the dependencies version of "esri-leaflet": "^3.0.0",

I'm actually not sure if we need both ... or if only having it listed in one or the other is better ... need to do some research.

from esri-leaflet-vector.

Well it depends. Do you expect your users to install it themselves? Or do you want it to be automatic - i.e., if you install esri-leaflet-geocoder, you get esri-leaflet automatically installed? My inclination would be to keep it under peerDependencies, considering this is a plugin for esri-leaflet, which itself is a plugin for leaflet. IMO, people using this (or geocoder) plugin should take ownership of their leaflet and esri-leaflet installations on their own first - so it should be a peerDep. That's just my humble 2 cents on the matter.

That being said, from what I understand, npm 7 now automatically installs all peerDependencies, so this may be a moot point for npm 7 users.

from esri-leaflet-vector.