FillConstraint ignores paddings by SiblingConstrains about elementa HOT 3 OPEN

Should be fixed by #75

from elementa.

Should be fixed by #75

I wish it’d get merged, it’s more than a year since 😭

from elementa.

I've closed the referenced PR as it has several shortcomings that make it unfit for general use.
If it works in your case, you could just create a local copy of it for your use.

Internally we've come to do something similar but with different tradeoffs than that PR, namely that it accounts for all SiblingConstraint-induced padding (or more generally any PaddingConstraint-induced padding) but not any offset induced in any other way. In particular your y = SiblingConstraint(3f) + 5f.pixels (which, given the aren't any preceding siblings (?) is just 5.pixels) wouldn't work. We've come to instead use dummy spacer components of appropriate size whenever we need extra padding at the very start/end.

Here's the relevant part of FillConstraint (at least the width; height works analogous) which we've modified:

        return if (useSiblings) {
            target.getWidth() - target.children.filter { it != component }.sumOf {
                it.getWidth().toDouble() + ((it.constraints.x as? PaddingConstraint)?.getHorizontalPadding(it) ?: 0f).toDouble()
            }.toFloat()
        } else target.getRight() - component.getLeft() + ((target.constraints.x as? PaddingConstraint)?.getHorizontalPadding(target) ?: 0f)

Beware that we only ever use it with useSiblings = true, so that else case is completely untested (and looking at it, idk what that's supposed to do; doesn't look right to me).

from elementa.