MacOS bug on 0.5.0 about local-ip-address HOT 6 CLOSED

@newdev8 thank you for raising this. @EstebanBorai, nice, quick fix. Curious that v0.5 introduced a bug, as we wrote specific logic to handle this case. I'll look into it, as macOS should not require a separate solution, I think.

from local-ip-address.

Interesting! Thanks for reporting @newdev8!
I will review it and get back to you!

from local-ip-address.

@jakewilliami I think we could reintroduce macOS specific approach and use https://github.com/EstebanBorai/local-ip-address/blob/main/src/bsd.rs only for BSD based instead.

Having a dedicated macOS looks like a better approach.

from local-ip-address.

@newdev8 I just did a draft here: #98 reintroducing macOS impl.
Can you tell me if it works for you please?

from local-ip-address.

@EstebanBorai thanks for your quick reply!

I've tested it and works like a charm 🍀.

from local-ip-address.

Oh dear, I think this is the logical mistake—this is the exact opposite filter we want! I inverted this and it works now on my macOS machine.

Before:

After:

Diff:

Obviously it's difficult to catch these "semantic" errors, as we can't test for exact local IP in our unit tests, unless we cross check it with ip -a or something like that. I wonder how we can avoid these errors in future. Thank you again @newdev8 for bringing this to our attention!

from local-ip-address.