Auto label PRs on Github about etcd HOT 9 CLOSED

Hi @jmhbnz , as far as I know, /lgtm command doesn't work. Is there any plan to use OWNERS file and enable /lgtm as review process?

from etcd.

Hi @jmhbnz , as far as I know, /lgtm command doesn't work. Is there any plan to use OWNERS file and enable /lgtm as review process?

Yes. But we need to work carefully and set up the nested OWNERS files that it would depend on. It's a gradual journey adopting the k/k prow features, want to make sure we don't try to do too much at once and cause problems. This auto labeling is a good driver for us to start creating nested OWNERS.

from etcd.

Very nice feature to have let me know if i can help with anything.

from etcd.

@jmhbnz was #17979 enough to have auto labeling working? Have you tested it?

Yes it is working now, example #17983:

I still need to check nesting for label hierarchy but basics are working :)

from etcd.

Agree this would be great to start bringing online. Thanks @liangyuanpeng for drafting the initial pr to enable it in kubernetes/test-infra: https://github.com/kubernetes/test-infra/pull/32589/files

For this to be helpful we do need to add nested OWNERS files with the label stanza, for example: https://github.com/kubernetes/kubernetes/blob/master/cluster/images/OWNERS

Nested OWNERS we have already discussed and have consensus to progress so I will write an initial suggestion of labels here shortly so we can raise the pr.

from etcd.

/assign @liangyuanpeng

from etcd.

@jmhbnz: GitHub didn't allow me to assign the following users: liangyuanpeng.

Note that only etcd-io members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

from etcd.

/assign

from etcd.

@jmhbnz was #17979 enough to have auto labeling working? Have you tested it?

from etcd.