Giter VIP home page Giter VIP logo

Comments (6)

eteeselink avatar eteeselink commented on May 18, 2024 1

Closing this issue because of low activity. Feel free to reopen if you hit this too.

from babel-plugin-transform-class-display-name.

eteeselink avatar eteeselink commented on May 18, 2024

Hey! Thanks for your comment.

I don't currently use React Native for anything, so "try it and see" amounts to "set up and learn a whole React Native dev environment", which I don't have time for.

However, I'd be happy to accept a pull request that fixes this. Do you have any idea where it goes wrong? Do you know whether it worked on earlier versions of React Native?

from babel-plugin-transform-class-display-name.

TSMMark avatar TSMMark commented on May 18, 2024

Hi, yes, sorry I should have been more detailed. It worked in React Native 0.38.x. Unfortunately, I have no idea where it is going wrong, as I am not very familiar with babel plugin architecture in general, and even less so with this specific plugin.

What I can say for sure is that after upgrading from 0.38 to 0.39, our react component classes no longer had the static property displayName at run time.

from babel-plugin-transform-class-display-name.

eteeselink avatar eteeselink commented on May 18, 2024

Impressive. In all honesty I have no good idea where to look. The RN changelog doesn't say anything about a change in how the react component base classes work or something.

You could help by making an example app of the tiniest possible RN application which exhibits this problem. I'm curious whether the babel output contains the displayName property correct in that setup, and whether it changed between RN 0.38 and 0.39. If there's no change there, then I'd wager there's no real bug in this plugin per se but RN does something to overwrite or remove the displayName property at runtime.

If that's the case, maybe we can come up with a workaround.

from babel-plugin-transform-class-display-name.

TSMMark avatar TSMMark commented on May 18, 2024

I think making an example app of the tiniest possible RN application which exhibits this problem is a great idea, but unfortunately, I won't be able to get to this anytime soon.

from babel-plugin-transform-class-display-name.

eteeselink avatar eteeselink commented on May 18, 2024

Ok. I'll leave this issue open in case someone else gets in trouble because of this and has an idea. Thanks for reporting!

from babel-plugin-transform-class-display-name.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.