Giter VIP home page Giter VIP logo

Comments (6)

tkipf avatar tkipf commented on June 26, 2024

We always (have to) condition the generative model on some initial trajectory, even at test time — in case this is what you refer to?

from nri.

kingwmk avatar kingwmk commented on June 26, 2024

the code in modules:

638 if dynamic_graph and step >= burn_in_steps:
639 # NOTE: Assumes burn_in_steps = args.timesteps
logits = encoder(
data[:, :, step - burn_in_steps:step, :].contiguous(),
rel_rec, rel_send)

from nri.

tkipf avatar tkipf commented on June 26, 2024

Yes, we are conditioning the generative model on an initial sub-sequence (a few steps of ‘real’ data) from which our model predicts future time steps. Of course we only evaluate the predictive quality on these ‘future’ time steps and discard the conditioning. This can be seen as a ‘burn-in’ phase for the recurrent generative model, as outlined in the code that you mentioned.

from nri.

kingwmk avatar kingwmk commented on June 26, 2024

Yes. However, When employing dynamic-graph in the test step, after burnin step the encoder still use the ground-truth data as " data[:, :, step - burn_in_steps:step, :] " to infer, so it sees ground truth data that should not be seen. Is it right in such case? I mean after burnin step, should the encoder use predicted data for the reasoning?

from nri.

kingwmk avatar kingwmk commented on June 26, 2024

Thank you for your kindness and timely response. Thank you very much for your contribution to the community! I am not malicious. I just want to exchange and discuss issues and learn from each other.

from nri.

tkipf avatar tkipf commented on June 26, 2024

I see what you're saying. Yes, this is indeed using a setting equivalent to teacher forcing to re-estimate the discrete latent graph (in the setting denoted by "dynamic graph"), but the decoder is only conditioned on its own past predictions + the discrete latent graph which can only communicate very little information about the (past) ground truth trajectory.

If you would like to deploy this in an online setting, you would have to use its own predictions even for dynamic graph re-estimation.

I agree that the green line in Figure 6a (Motion capture data), which is the only result we show that uses this setting, might be slightly affected by this and should be interpreted with care.

from nri.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.