Comments (5)
slel
commented on June 17, 2024
Maybe use the issue tracker at the old Embedmedia repo
https://github.com/redhog/ep_embedmedia
until an issue tracker is opened at the new one
https://github.com/ether/ep_embedmedia
See this issue about improving this situation:
from ep_embedmedia.
rhansen
commented on June 17, 2024
I enabled issues for ep_embededmedia and moved this issue there.
from ep_embedmedia.
JohnMcLear
commented on June 17, 2024
Apologies: FWIW I can't replicate this with minify: false and maxAge: 0
Can anyone else replicate?
from ep_embedmedia.
lisandi
commented on June 17, 2024
I can replicate it on all our machines. I tried to get behind that secret why it is working for you but not here but was not successful until now.
- We installed a completely new fresh etherpad from github
- we installed ONLY embedmedia - but get to the same result
what else we did:
- cleared all files in var - but those minified files get constantly created even minified is set to false
- we did check back on 3 other machines here in our office with same result
- we created a new empty database and used that one but the same result
Browser is Chrome on MacOSX but we tried also Safari and Maxthon and get same results here.
But what we found out was the following - probably not related to it but perhaps it is
as we run a settings-lite.json file and credentials-lite.json file from outside the git source folders
we realized that the settings.json file which gets displayed in admin/settings is always the one located in the git/source folder and not the actual one which gets used.
When starting etherpad it shows the folders the settings and the credentials files used are located
We named the one located in etc/etherpad "Paddy etc"
But when checking in /admin/settings you see "Paddy original" which is the file located in the original location inside the etherpad-lite folder downloaded from GitHub.
in the Browser Tab title, you see "Paddy etc" when loading
we counterchecked and changed the Port to 9002 while the Proxy looks for 9001 and the site is gone - or comes back when reenabling 9001 as port - this means it is definitely serving the files shown in the "black" first screenshot and NOT the settings file shown in /admin/settings - all changes you perform there are more or less useless!
--
We also saw that in etherpad-lite/var lots of minified files get created despise the fact that minified is set to false and "0"
--
As it was an empty fresh etherpad installation
we installed eb_embedmedia from admin/plugins
but on all our machines (all Mac) the embedmedia icon did not show up nor did the button work at all (open up the modal window as it is supposed to)
Finally we tried it again with a completely empty new database - cleared again all caches, disabled Cloudflare but no changes
Here is the admin/troubleshooting information
Etherpad version
Version number: 1.8.14
Latest available version: 1.8.14
Git sha: 4d28394
Installed plugins
ep_embedmedia
ep_etherpad-lite
Installed parts
ep_etherpad-lite/openapi
ep_etherpad-lite/adminsettings
ep_etherpad-lite/adminplugins
ep_etherpad-lite/admin
ep_etherpad-lite/tests
ep_etherpad-lite/socketio
ep_etherpad-lite/errorhandling
ep_etherpad-lite/importexport
ep_etherpad-lite/apicalls
ep_etherpad-lite/webaccess
ep_etherpad-lite/padurlsanitize
ep_etherpad-lite/specialpages
ep_etherpad-lite/i18n
ep_etherpad-lite/stats
ep_etherpad-lite/static
ep_etherpad-lite/express
ep_etherpad-lite/Minify
ep_etherpad-lite/DB
ep_embedmedia/embedmedia
Installed hooks
Server-side hooks
createServer:
ep_etherpad-lite:
express:
ep_etherpad-lite/node/hooks/express
eejsBlock_body:
ep_embedmedia:
embedmedia:
ep_embedmedia/hooks:eejsBlock_body
eejsBlock_editbarMenuLeft:
ep_embedmedia:
embedmedia:
ep_embedmedia/hooks:eejsBlock_editbarMenuLeft
eejsBlock_scripts:
ep_embedmedia:
embedmedia:
ep_embedmedia/hooks:eejsBlock_scripts
eejsBlock_styles:
ep_embedmedia:
embedmedia:
ep_embedmedia/hooks:eejsBlock_styles
expressCloseServer:
ep_etherpad-lite:
socketio:
ep_etherpad-lite/node/hooks/express/socketio
expressConfigure:
ep_etherpad-lite:
webaccess:
ep_etherpad-lite/node/hooks/express/webaccess
expressCreateServer:
ep_etherpad-lite:
admin:
ep_etherpad-lite/node/hooks/express/admin
adminplugins:
ep_etherpad-lite/node/hooks/express/adminplugins
adminsettings:
ep_etherpad-lite/node/hooks/express/adminsettings
apicalls:
ep_etherpad-lite/node/hooks/express/apicalls
errorhandling:
ep_etherpad-lite/node/hooks/express/errorhandling
i18n:
ep_etherpad-lite/node/hooks/i18n
importexport:
ep_etherpad-lite/node/hooks/express/importexport
openapi:
ep_etherpad-lite/node/hooks/express/openapi
padurlsanitize:
ep_etherpad-lite/node/hooks/express/padurlsanitize
socketio:
ep_etherpad-lite/node/hooks/express/socketio
specialpages:
ep_etherpad-lite/node/hooks/express/specialpages
static:
ep_etherpad-lite/node/hooks/express/static
tests:
ep_etherpad-lite/node/hooks/express/tests
restartServer:
ep_etherpad-lite:
express:
ep_etherpad-lite/node/hooks/express
shutdown:
ep_etherpad-lite:
DB:
ep_etherpad-lite/node/db/DB
express:
ep_etherpad-lite/node/hooks/express
Minify:
ep_etherpad-lite/node/utils/Minify
stats:
ep_etherpad-lite/node/stats
socketio:
ep_etherpad-lite:
adminplugins:
ep_etherpad-lite/node/hooks/express/adminplugins
adminsettings:
ep_etherpad-lite/node/hooks/express/adminsettings
socketio:
ep_etherpad-lite/node/handler/PadMessageHandler
Client-side hooks
aceAttribsToClasses:
ep_embedmedia:
embedmedia:
ep_embedmedia/static/js/hooks:aceAttribsToClasses
aceCreateDomLine:
ep_embedmedia:
embedmedia:
ep_embedmedia/static/js/hooks:aceCreateDomLine
aceInitInnerdocbodyHead:
ep_embedmedia:
embedmedia:
ep_embedmedia/static/js/hooks:aceInitInnerdocbodyHead
We tried the rewrite rules but were struggling to get them working for proxies to subfolders.
Our systemd/system/etherpad-lite.service
[Unit]
Description=Etherpad-lite, the collaborative editor.
After=syslog.target network.target
[Service]
Type=simple
User=etherpad
Group=etherpad
WorkingDirectory=/opt/etherpad/etherpad-lite
Environment=NODE_ENV=production
ExecStart=/usr/bin/node /opt/etherpad/etherpad-lite/src/node/server.js --settings /etc/etherpad/settings-lite.json --credentials /opt/etherpad/config/credentials-lite.json
Restart=always
RestartSec=5
SyslogIdentifier=etherpad
StandardOutput=syslog
StandardError=syslog
[Install]
WantedBy=multi-user.target
Our Apache Proxy Settings where on its root HumHub is running and in /pad/ the etherpad
<VirtualHost 12.34.56.78:80>
SuexecUserGroup #1234 #1234
ServerName our.domain
ServerAlias www.our.domain
DocumentRoot /home/our-user/public_html
ErrorLog /var/log/virtualmin/our.domain_error_log
CustomLog /var/log/virtualmin/our.domain_access_log combined
ScriptAlias /cgi-bin/ /home/our-user/cgi-bin/
DirectoryIndex index.html index.htm index.php index.php4 index.php5
<Directory /home/our-user/public_html>
Options -Indexes +IncludesNOEXEC +SymLinksIfOwnerMatch
allow from all
AllowOverride All Options=ExecCGI,Includes,IncludesNOEXEC,Indexes,MultiViews,SymLinksIfOwnerMatch
Require all granted
</Directory>
<Directory /home/our-user/cgi-bin>
allow from all
AllowOverride All Options=ExecCGI,Includes,IncludesNOEXEC,Indexes,MultiViews,SymLinksIfOwnerMatch
Require all granted
</Directory>
RewriteEngine on
RemoveHandler .php
RemoveHandler .php7.4
RemoveHandler .php8.0
<FilesMatch \.php$>
SetHandler proxy:fcgi://localhost:8009
</FilesMatch>
# Proxy Settings
ProxyVia On
ProxyRequests Off
ProxyPreserveHost on
RewriteEngine On
# Etherpad lite
RewriteRule ^/pad$ /pad/ [R]
ProxyPass /pad/ http://127.0.0.1:9001/ retry=0 timeout=30
ProxyPassReverse /pad/ http://127.0.0.1:9001/
<Location /socket.io>
# This is needed to handle the websocket transport through the proxy, since
# etherpad does not use a specific sub-folder, such as /ws/ to handle this kind of traffic.
# Taken from https://github.com/ether/etherpad-lite/issues/2318#issuecomment-63548542
# Thanks to beaugunderson for the semantics
RewriteCond %{QUERY_STRING} transport=websocket [NC]
RewriteRule /pad/(.*) ws://127.0.0.1:9001/socket.io/$1 [P,L]
ProxyPass http://127.0.0.1:9001/socket.io retry=0 timeout=30
ProxyPassReverse http://127.0.0.1:9001/socket.io
</Location>
# Whiteboard
RedirectMatch ^/wbo$ /wbo/
RewriteCond %{HTTP:Connection} Upgrade [NC]
RewriteCond %{HTTP:Upgrade} websocket [NC]
RewriteRule /wbo/(.*) ws://127.0.0.1:5001/$1 [P,L]
ProxyPass /wbo/ http://127.0.0.1:5001/
ProxyPassReverse /wbo/ http://127.0.0.1:5001/
<Proxy *>
Options FollowSymLinks MultiViews
AllowOverride All
Order allow,deny
allow from all
</Proxy>
</VirtualHost>
<VirtualHost 12.34.56.78:443>
SuexecUserGroup #1234 #1234
ServerName our.domain
ServerAlias www.our.domain
DocumentRoot /home/our-user/public_html
ErrorLog /var/log/virtualmin/our.domain_error_log
CustomLog /var/log/virtualmin/our.domain_access_log combined
ScriptAlias /cgi-bin/ /home/our-user/cgi-bin/
DirectoryIndex index.html index.htm index.php index.php4 index.php5
<Directory /home/our-user/public_html>
Options -Indexes +IncludesNOEXEC +SymLinksIfOwnerMatch
allow from all
AllowOverride All Options=ExecCGI,Includes,IncludesNOEXEC,Indexes,MultiViews,SymLinksIfOwnerMatch
Require all granted
</Directory>
<Directory /home/our-user/cgi-bin>
allow from all
AllowOverride All Options=ExecCGI,Includes,IncludesNOEXEC,Indexes,MultiViews,SymLinksIfOwnerMatch
Require all granted
</Directory>
RewriteEngine on
RemoveHandler .php
RemoveHandler .php7.4
RemoveHandler .php8.0
<FilesMatch \.php$>
SetHandler proxy:fcgi://localhost:8009
</FilesMatch>
SSLEngine on
SSLCertificateFile /home/our-user/ssl.cert
SSLCertificateKeyFile /home/our-user/ssl.key
SSLProtocol all -SSLv2 -SSLv3 -TLSv1 -TLSv1.1
SSLCACertificateFile /home/our-user/ssl.ca
# Proxy Settings
ProxyVia On
ProxyRequests Off
ProxyPreserveHost on
RewriteEngine On
# Etherpad lite
RewriteRule ^/pad$ /pad/ [R]
ProxyPass /pad/ http://127.0.0.1:9001/ retry=0 timeout=30
ProxyPassReverse /pad/ http://127.0.0.1:9001/
#<Location /socket.io>
# This is needed to handle the websocket transport through the proxy, since
# etherpad does not use a specific sub-folder, such as /ws/ to handle this kind of traffic.
# Taken from https://github.com/ether/etherpad-lite/issues/2318#issuecomment-63548542
# Thanks to beaugunderson for the semantics
RewriteCond %{QUERY_STRING} transport=websocket [NC]
RewriteRule /pad/(.*) ws://127.0.0.1:9001/socket.io/$1 [P,L]
ProxyPass /pad/ http://127.0.0.1:9001/socket.io retry=0 timeout=30
ProxyPassReverse /pad/ http://127.0.0.1:9001/socket.io
#</Location>
# Whiteboard
RedirectMatch ^/wbo$ /wbo/
RewriteCond %{HTTP:Connection} Upgrade [NC]
RewriteCond %{HTTP:Upgrade} websocket [NC]
RewriteRule /wbo/(.*) ws://127.0.0.1:5001/$1 [P,L]
ProxyPass /wbo/ http://127.0.0.1:5001/
ProxyPassReverse /wbo/ http://127.0.0.1:5001/
<Proxy *>
Options FollowSymLinks MultiViews
AllowOverride All
Order allow,deny
allow from all
</Proxy>
</VirtualHost>
We tried the rewrite but it is producing a circle like pad/pad/pad/..... and when we take over from the tutorial - unmodified - it won't work
RewriteEngine On
RewriteRule /pad/p/*$ https://our.domain/pad/ [NC,L]
RewriteRule /p/*$ https://our.domain/pad/ [NC,L]
RewriteCond %{REQUEST_URI} !^/pad/locales/
RewriteCond %{REQUEST_URI} !^/pad/locales.json
RewriteCond %{REQUEST_URI} !^/pad/admin
RewriteCond %{REQUEST_URI} !^/pad/p/
RewriteCond %{REQUEST_URI} !^/pad/static/
RewriteCond %{REQUEST_URI} !^/pad/pluginfw/
RewriteCond %{REQUEST_URI} !^/pad/javascripts/
RewriteCond %{REQUEST_URI} !^/pad/socket.io/
RewriteCond %{REQUEST_URI} !^/pad/ep/
RewriteCond %{REQUEST_URI} !^/pad/minified/
RewriteCond %{REQUEST_URI} !^/pad/api/
RewriteCond %{REQUEST_URI} !^/pad/ro/
RewriteCond %{REQUEST_URI} !^/pad/error/
RewriteCond %{REQUEST_URI} !^/pad/jserror
RewriteCond %{REQUEST_URI} !^/pad/redirect
RewriteCond %{REQUEST_URI} !/pad/favicon.ico
RewriteCond %{REQUEST_URI} !/pad/robots.txt
RewriteRule ^/pad/+(.+)$ https://our.domain/pad/$1 [L]
Not sure what is wrong - sorry!
from ep_embedmedia.
lisandi
commented on June 17, 2024
Working now by changing the absolute links to relative links
Unfortunately can't edit or fork that repository! perhaps you can enable that.
The following needs to get changed:
in ep_embedmedia/templates/styles.ejs change
<link rel="stylesheet" href="/static/plugins/ep_embedmedia/static/css/main.css" type="text/css" />
to
<link rel="stylesheet" href="../static/plugins/ep_embedmedia/static/css/main.css" type="text/css" />
and in ep_embedmedia/templates/scripts.ejs change
<script src="/static/plugins/ep_embedmedia/static/js/html4-defs.js"></script>
<script src="/static/plugins/ep_embedmedia/static/js/html-sanitizer.js"></script>
<script src="/static/plugins/ep_embedmedia/static/js/main.js"></script>
to
<script src="../static/plugins/ep_embedmedia/static/js/html4-defs.js"></script>
<script src="../static/plugins/ep_embedmedia/static/js/html-sanitizer.js"></script>
<script src="../static/plugins/ep_embedmedia/static/js/main.js"></script>
from ep_embedmedia.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ep_embedmedia.