Giter VIP home page Giter VIP logo

Comments (11)

dmitrizagidulin avatar dmitrizagidulin commented on May 18, 2024

@shawticus Excellent.
How do you feel about modeling this (or at least being able to export to) a vCard Group? (which means it'll sync natively with iOS and Android groups, etc)

from etherealengine.

lalalune avatar lalalune commented on May 18, 2024

Sounds good to me

from etherealengine.

lalalune avatar lalalune commented on May 18, 2024

Changed this so that group members all have an isLeader flag -- there is no 'owner' of the group.

We will need to review logic to delete the group when all members leave.

from etherealengine.

lalalune avatar lalalune commented on May 18, 2024

@SaadAhmedSiddiqui when you've finished your current task, please take a look at this. We've redefined our models quite a bit and need to update the group assignment logic. I believe most of the group code is commented out.

from etherealengine.

SaadAhmedSiddiqui avatar SaadAhmedSiddiqui commented on May 18, 2024

@shawticus same for this!

from etherealengine.

lalalune avatar lalalune commented on May 18, 2024

@barankyle please review

from etherealengine.

dmitrizagidulin avatar dmitrizagidulin commented on May 18, 2024

@SaadAhmedSiddiqui Is there a PR of the code in progress we can look at?

from etherealengine.

SaadAhmedSiddiqui avatar SaadAhmedSiddiqui commented on May 18, 2024

@dmitrizagidulin there is no PR for this because Step#4 is not completed yet

from etherealengine.

dmitrizagidulin avatar dmitrizagidulin commented on May 18, 2024

@SaadAhmedSiddiqui That's fine, can you please make a PR of the code in progress, before step 4?

from etherealengine.

mrhegemon avatar mrhegemon commented on May 18, 2024

Review and close
#168
#217

from etherealengine.

barankyle avatar barankyle commented on May 18, 2024

Mostly implemented as part of #345. Parties work very similarly to groups. The requirement that there must be two people in a party has been ignored for now. Logic for invites to all party members to join a world hasn't been done since joining worlds is still in progress; a new issue should be created when we want to do that.

from etherealengine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.