Giter VIP home page Giter VIP logo

Comments (6)

pipermerriam avatar pipermerriam commented on August 17, 2024 2

@palango 👍 to making genesis parameters configurable.

I'd rather do this as an optional constructor parameter to the PyEVMBackend to allow supplying genesis_params. I think adding genesis_state would also be beneficial, but that part could be more tricky since we also have to initialize the default accounts and there is a question of whether genesis_state should be merged with the default account state, or whether it should fully override it...

genesis_params = get_default_genesis_params()
account_keys = get_default_account_keys()
genesis_state = generate_genesis_state(account_keys)

@voith I think your last option is what I'm talking about

providing config as a parameter to the entry point(I'm fairly new to this project and I don't know the entry point)?

The entry point in question would be the PyEVMBackend class instantiation.

from eth-tester.

voith avatar voith commented on August 17, 2024

@palango just curious to know how you'd make such constants configurable. Are you thinking of something like django settings, env variables or providing config as a parameter to the entry point(I'm fairly new to this project and I don't know the entry point)?

from eth-tester.

palango avatar palango commented on August 17, 2024

Making the genesis parameters constructor parameters sounds good and usable to me. Adding genesis state would surely be useful with large contract systems. Here it would be good if it is nicely integrated with the snapshot system, i.e. using snapshots of a chain as genesis state.

from eth-tester.

pipermerriam avatar pipermerriam commented on August 17, 2024

@palango do you think you have enough context to either:

  • update this issue with a reasonable spec for providing genesis params
  • create a new issue speccing thing out?

RE: snapshots, I do think that's a solid API for eth-tester to implement but I'd push that out into a separate issue/ticket.

from eth-tester.

palango avatar palango commented on August 17, 2024

@pipermerriam I'm in vacation right now and will look into this afterwards.

from eth-tester.

carver avatar carver commented on August 17, 2024

This is possible (though not pleasant yet), so I'll close. There's a tracking issue for making it better: #129

from eth-tester.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.