Giter VIP home page Giter VIP logo

Comments (11)

ArnasAlex avatar ArnasAlex commented on June 9, 2024 5

Started to get the same issue after MetaMask browser extension was updated on chrome. Using ETH Sepolia network.
MetaMask Version
11.14.5

Using Firefox with older MetaMask version works correctly (same as before promise is resolved when tx was submitted and not on tx confirmation).
MetaMask Version
11.12.4

from ethers.js.

usame-algan avatar usame-algan commented on June 9, 2024 4

Can confirm that I have the same issues with Metamask since one of their last updates. Calling signer.sendTransaction or contract.connect(signer).<any method> gets stuck until the transaction is executed.

One workaround is to use sendUncheckedTransaction. I think it doesn't officially exist in v6 anymore but we copied it from v5:

export class UncheckedJsonRpcSigner extends JsonRpcSigner {
  async sendTransaction(transaction: TransactionRequest): Promise<TransactionResponse> {
    return this.sendUncheckedTransaction(transaction).then((hash) => {
      return <TransactionResponse>(<unknown>{
        hash,
        nonce: null,
        gasLimit: null,
        gasPrice: null,
        data: null,
        value: null,
        chainId: null,
        confirmations: 0,
        from: null,
        wait: (confirmations?: number) => {
          return this.provider.waitForTransaction(hash, confirmations)
        },
      })
    })
  }
}

// How to use it:
const uncheckedJsonRpcSigner = new UncheckedJsonRpcSigner(signer.provider, await signer.getAddress())
const result = await uncheckedJsonRpcSigner.sendTransaction(...)
// will resolve immediately

from ethers.js.

ip10x avatar ip10x commented on June 9, 2024 3

Just chiming in to say this is happening to me as well. Using ethers 6.10.0 and MetaMask on Sepolia or my local node

Code looks like

const tx = await contract.function(<function args>)

const txHash = tx.hash

...

My app is sorta breaking cause it's expecting to get the txHash back immediately and redirect to an intermediate page while the transaction is waiting to be confirmed (it contains the await tx.wait()). Now it skips the intermediate page.

from ethers.js.

IttsKK avatar IttsKK commented on June 9, 2024 2

I've tested this on BNB Smart Chain and locally with Hardhat. Everything was working fine up until about a week ago, and I haven't made any changes to the relevant parts of my codebase since then. I suspect this may be an issue with Metamask, but I thought it would be good to ask here as well.

from ethers.js.

kaptn3 avatar kaptn3 commented on June 9, 2024 2

Same problem

from ethers.js.

cosullivan avatar cosullivan commented on June 9, 2024 1

I've tested this on BNB Smart Chain and locally with Hardhat. Everything was working fine up until about a week ago, and I haven't made any changes to the relevant parts of my codebase since then. I suspect this may be an issue with Metamask, but I thought it would be good to ask here as well.

Did you figure this out? I've now just noticed the same same thing on BNB & Arbitrum.

from ethers.js.

ricmoo avatar ricmoo commented on June 9, 2024 1

I've contacted MetaMask to find out more about any recent changes. :)

from ethers.js.

ricmoo avatar ricmoo commented on June 9, 2024

That is how tx = await contract.func() works; returning once the transaction is in the mempool. Calling await tx.wait() will then wait for it to be mined, resolving to the receipt. But the initial call certainly doesn't wait for the tx to be mined.

Can you provide an example where you do not believe this is happening?

from ethers.js.

IttsKK avatar IttsKK commented on June 9, 2024

I understand that await contract.func() is expected to resolve as soon as the transaction reaches the mempool, with await tx.wait() then waiting for the transaction's confirmation. However, I am experiencing behavior that suggests the initial await on the transaction function is waiting until the transaction is confirmed before resolving.

  • Environment: I am running this within a React application, interacting with the network via MetaMask and ethers.
  • Code Snippet:
    const amountToApprove = ethers.parseEther(tokenAmount);
    console.log("Approving Tokens");
    const approve = await paymentTokenContract.approve(tokenSaleAddress, amountToApprove);
    console.log("Tokens Approved, Awaiting Confirmation");
    await approve.wait();
    console.log("Approval Confirmed, Initiating Purchase");
    const tx = await tokenSaleContract.buyTokens(paymentTokenAddress, amountToApprove);
    console.log("Purchase Transaction Submitted, Awaiting Confirmation");
    await tx.wait();
    console.log("Purchase Confirmed");

Observed Behavior:

  • The logs "Tokens Approved, Awaiting Confirmation" and "Purchase Transaction Submitted, Awaiting Confirmation" are expected to print immediately after the respective transactions (approve and buyTokens) are sent to the network.
  • However, these logs only appear after each transaction has been confirmed on the blockchain. This indicates that the await on both approve and buyTokens does not resolve upon submission to the mempool but rather waits until the transaction is confirmed.

from ethers.js.

ricmoo avatar ricmoo commented on June 9, 2024

What network are you on? Since ethers needs to lookup the tx from the mempool, this can happen on networks (or backends) which do not return transactions in the mempool.

from ethers.js.

sp1r1don avatar sp1r1don commented on June 9, 2024

Hello guys. If anyone have same issue with contract.METHOD() and tx.wait

  1. @gmxer nice solution!
  2. https://github.com/gmx-io/gmx-interface/blob/8e0eb420aa71e63720ba78f17f0117c1ce555810/src/lib/rpc/UncheckedJsonRpcSigner.ts

from ethers.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.