GET request /favicon.ico should return our favicon about swarm HOT 12 CLOSED

@gbalint this has been resolved and merged into ethereum/go-ethereum:

ethereum/go-ethereum#15958 (comment)

from swarm.

I'd prefer a local response instead of a bzz request. It should work on private networks too (or even on offline hosts.)

from swarm.

@homotopycolimit So that means it's included in the local installation?

from swarm.

yes. local. it's only a tiny favicon after all

from swarm.

@homotopycolimit okay, i'd be happy to open up a branch

from swarm.

sure. go ahead.

from swarm.

@homotopycolimit this is a solution I found on SO after much hunting. let me know what you think.

from swarm.

http://localhost:8500/favicon.ico gives me an HTTP error 400 page, no favicon. Am I doing something wrong?
(built swarm using swarm-network-rewrite branch on ethersphere on June 17 2018, commit 86c5515)

from swarm.

@homotopycolimit it's been a minute, but i believe we discussed using data blobs rather than putting a file locally. so, you're not getting an error, the .ico is a data blob rather than a file.

from swarm.

All that interests me is what an HTTP request to /favicon.ico returns.
File vs datablob means very little to me.

from swarm.

so on a running swarm node, we should get the icon at http://localhost:8500/favicon.ico

from swarm.

from swarm.