Giter VIP home page Giter VIP logo

Comments (7)

simonlynen avatar simonlynen commented on July 2, 2024

@flaviofontana sorry for the delay on this. I agree with your suggestion and I would be happy see these fixed in the framework. The unit of the measurement noise on the orientation is expressed in radians.

from ethzasl_msf.

fboris avatar fboris commented on July 2, 2024

I'm glad to see your improvement. I was struggling with this "unit problem".

from ethzasl_msf.

flaviofontana avatar flaviofontana commented on July 2, 2024

@simonlynen Thanks for your reply I started working on integrating the comments, I also took the liberty to modify the pose_sensor config file and add comments. Let me know if this approach is ok for you
https://github.com/flaviofontana/ethzasl_msf/commit/d8afeffa65ebaac63560ce0fd059dde147fc9e6f

I still have two open questions

  • in your config you estimate for example the scale, however you set the process noise to zero, is this correct or should we set it to something small (what is small)?
    pose_sensor/pose_fixed_scale: false pose_sensor/pose_noise_scale: 0.0
  • for pose_noise_meas_q do you use the convention of the ros pose msg?
    meaning I can compute this value from experimental data as follows
    • record N+1 orientation measurements with sensor at rest -> q0, .... , qN
    • transform the N quaternion to the three euler angles -> phi0, ... phiN; theta0,... thetaN; psi0,...,psiN
    • compute the std dev for each angle phi, theta, psi -> take the mean of the three

cheers,
flavio

from ethzasl_msf.

simonlynen avatar simonlynen commented on July 2, 2024

@flaviofontana yes, the changelist looks great!

qs:

  1. We usually have seen no large scale drifts and thus prefered to keep the covariance for the scale a bit tighter by leaving it at zero.
  2. yes that would be ok to do. Of course it is better if you get these values from your pose-computation algorithm and not use a fixed measurement noise covariance.

from ethzasl_msf.

flaviofontana avatar flaviofontana commented on July 2, 2024

@simonlynen Thanks again for your answers.

  1. but even with 0 covariance the scale will be estimated?
    For the examle config, should be set it to e-10 just to make a point that when somevalue it not fixed processnoise needs to be defined?

I will finish it tmrw and send then a pull request.

flavio

from ethzasl_msf.

simonlynen avatar simonlynen commented on July 2, 2024

@flaviofontana yes, the additional inflation of the covariance for the scale estimate can be used to model larger drifts in the scale of the SLAM system. The scale is estimated independently from that.

I would prefer if you left it at zero like the covariance inflation on the extrinsic calibration.

from ethzasl_msf.

simonlynen avatar simonlynen commented on July 2, 2024

@flaviofontana Please take a look at this definitions here and try to either point to these or adopt as much of the notation as possible: https://github.com/ethz-asl/kalibr/wiki/IMU-Noise-Model-and-Intrinsics

from ethzasl_msf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.