intended form of zero in bitfields? about stm32wb55 HOT 5 CLOSED

sure! that's perfectly fine. I didn't read up on bitfields enough toknow that the zeros could be put in them too, I'm pretty new to rust :)

from stm32wb55.

I've usd CharacteristicEvent::empty() but ... is that really the best way?

from stm32wb55.

@karlp does this looks ok? https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=74f2593ee25960645b5d838d74db1640

from stm32wb55.

Were you going to add this to the module? or just show how I could do it in general? Should also apply to CharacteristicPermission as well?

Looking at AN5270 for ACI_GATT_ADD_CHAR, it should get 0s defined for CharacteristicProperty, CharacteristicPermission, CharacteristicEvent,

For ACI_GATT_ADD_CHAR_DESC, there's 0, and some higher numbers missing from DescriptorPermission, AccessPermission

For ACI_GATT_UPDATE_CHAR_VALUE_EXT, the 0 should be added to UpdateType

I can make a PR for this is you'd prefer?

from stm32wb55.

@karlp

I can make a PR for this is you'd prefer?

Sure, go ahead! That would be great!

from stm32wb55.