Comments (5)
Arguably it's post-5.10.1 that's broken... for MS purposes. :-)
Actually, though, it's the test that's broken.
Cut-and-paste error. Mea culpa!
The line:
is( Stuff->copy_cat("wibble", ""), "wibble" );
should be:
is( Stuff->copy_cat("wibble", 0), "wibble" );
from method-signatures.
BTW, the new new smartmatch semantics currently proposed
for 5.18 are going to mess this mechanism up again and will
necessitate a rewrite to support backwards compatibility. I'll volunteer
to provide that rewrite when the time comes, as I'll have to do the
same for various other modules that rely on 5.10.1 smartmatching
semantics.
from method-signatures.
I think the behavior of when
needs to be clarified. The examples in the
docs make it pretty clear that it's an exact match.
# Use default if no argument passed OR argument is undef
method get_results($how_many = 1 when undef) {...}
# Use default if no argument passed OR argument is empty string
method get_results($how_many = 1 when "") {...}
# Use default if no argument passed OR argument is zero
method get_results($how_many = 1 when 0) {...}
If that's the case, if when is going to try and differentiate undef from 0
from empty string, the test needs all of them.
is( Stuff->copy_cat("wibble"), "wibble" );
is( Stuff->copy_cat("wibble", 0), "wibble" );
is( Stuff->copy_cat("wibble", ""), "" ); # fails in 5.10.1 and up
is( Stuff->copy_cat("wibble", undef), undef );
I would suggest not using smart match. It's unstable across versions and
doing it wrong for a large spread of them (5.10.1 to now). I'm guessing its
there to avoid having to play the "is this a number or a string" game which is
an equally obnoxious hassle.
Alternatively we special case empty string.
Alternatively we define "when" as "whatever smart match does".
If we're going to use smart match, I like the last one. We don't have to work
around smart match changes. It also means things like "when []" or "when {}"
are legit without us having to explain anything.
from method-signatures.
I think we ought to go with "whatever smartmatch does".
If they need to be more specific, there's always:
method get_results($how_many = 1 when qr/^0$/) {...}
or:
use Smart::Match 'numwise';
method get_results($how_many = 1 when numwise 0) {...}
They're going to have to get used to being more specific anyway,
once 5.18 is out.
Damian
from method-signatures.
Okay, this was causing 12 of the 17 failures on CPAN Testers. Fixed as per @thoughtstream suggested. I'm closing this one down.
from method-signatures.
Related Issues (20)
- Allow bare sigils as placeholders HOT 1
- Benchmarks vs 5.20
- Type checks should be done after default is applied. HOT 3
- Line numbers offset when signature has spaces in it HOT 9
- Type checking of defaults
- Multi-line defaults are broken HOT 1
- ($a, $b?, $c) should be a compile error HOT 1
- Type error in earlier Perl versions on Windows
- Anonymous functions which are a key in a hash will get the line number of the hash declaration. HOT 2
- Become a wrapper around Function::Parameters HOT 10
- Change Any::Moose for Moo HOT 4
- Getting "The type is unrecognized" if spaces are added HOT 1
- libmethod-signatures-perl: depends on libdata-alias-perl, broken with Perl 5.24
- support Type::Tiny HOT 33
- Support 'method BUILD' for Moo.* HOT 7
- Data::Alias is still required in 20131010 HOT 3
- t/thread-bug.t crashes on Mac OS X with threading enabled HOT 4
- Deprecate `@_` in favor of `...` HOT 1
- Move to evalEmpire org HOT 4
- Allow attributes between sub name and signature HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from method-signatures.