Giter VIP home page Giter VIP logo

Comments (7)

schwern avatar schwern commented on June 16, 2024

OIC it thinks its a block. Patch on the way.

from method-signatures.

schwern avatar schwern commented on June 16, 2024

Hrm. I can special case an empty hash, but what about hashes in general? I don't think there will be much call for checking for anything but an empty hash, so I'm inclined to just special case it. Anything more complicated can be done as a full block.

from method-signatures.

thoughtstream avatar thoughtstream commented on June 16, 2024

Hashes in general are already supported.

PPI uses the usual perlish guesswork to determine
whether a pair of curlies are a hash or a block.

Empty curlies are arguably a useless special case
as an empty hash will never smartmatch anything.

Of course, treating {} as an empty block would be
equally useless, so special casing them as empty
hash is probably for the best (i.e. least surprising).

from method-signatures.

barefootcoder avatar barefootcoder commented on June 16, 2024

Well, we should probably special-case it as whatever-doesn't-generate-a-syntax-error. :-D

This fix will go into the next dev release. Just waiting now for CPANTesters to throw up some reports for me to look at ...

from method-signatures.

schwern avatar schwern commented on June 16, 2024

@thoughtstream PPI might have that guesswork, but inject_for_sig() isn't using it. It's using a regex. I'll look at switching it to PPI, but this fix to the existing regex should go in.

And an empty hash ref smart matches, surprise, an empty hash ref.

perl -wle '$h = {};  print $h ~~ {} ? "Match" : "No Match" '
Match

perl -wle '$h = { foo => 23 };  print $h ~~ {} ? "Match" : "No Match" '
No Match

This is handy for providing a default if the user passes in an empty hash ref, similar to using when "" for a string parameter.

from method-signatures.

thoughtstream avatar thoughtstream commented on June 16, 2024

Very good point re empty hashref matching empty hashes.
This definitely should be special-cased.

from method-signatures.

barefootcoder avatar barefootcoder commented on June 16, 2024

Fixed in version 20121201.

from method-signatures.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.