Restore license headers to external files about blind-jump-portable HOT 8 CLOSED

I'll add the licences everywhere for now, and remove unused files later.

from blind-jump-portable.

It's not exactly that I copied the files and removed the licenses, you'll notice that some of the files don't even have the same names. I didn't want to have to link to the libgba library just for these files, and I copied the assembly instructions into these files, and probably didn't bother to copy the comment block at the top of the file. Now that I look at this licensing, does this mean that I need to convert this project to gpl, or just make the project open source, as I'm already doing?

P.s. Tonc, along with devkit arm, are specifically credited in the special thanks section of the in-game credits, I'm not trying to steal credit for other people's work. https://github.com/evanbowman/blind-jump-portable/blob/master/source/state/endingCreditsState.cpp#L67

from blind-jump-portable.

Yeah, the files don't have the same names, but the content is the same. I understand not wanting to link with libgba just for 2 or 3 files, to be honest, but the fix is really easy in this case.

libgba is LGPL. I'm not sure how it works when you link it statically, to be fair. The thing is, your game is MIT, which is less restrictive than LGPL, so all you have to do is keep it as it is, open source, and restore the headers.

Giving credit is nice, but if the files don't have the right copyright, whoever copies them from your game doesn't know where they came from or the license they have, and they may assume they are MIT-licensed.

EDIT: libtonc is MIT-licensed as well, even though that's not as clear. devkitPro/libtonc#4

from blind-jump-portable.

Ah I see, just a minute, I'll fix the files.

from blind-jump-portable.

Actually, I don't even think that I'm using any of the code from bios_math.s, at first I thought that these math routines from the bios were actually faster than the emulated division from devkitarm compiler, but turns out that there isn't really any significant difference, and in some cases, the compiler can optimize the emulated division better, because it has no concept really of what the assembly instructions in the bios look like.

from blind-jump-portable.

Ok, I added back the licenses. For memcpy.s, which never had a license attached to the file in the first place, I inserted the licence, from the PR that you linked, at the top of the file. Let me know if this is acceptable.

https://github.com/evanbowman/blind-jump-portable/blob/master/source/platform/gba/memcpy.s

from blind-jump-portable.

Works for me.

from blind-jump-portable.

Cool, thanks for your suggestions.

from blind-jump-portable.