Comments (3)
Looking over the codebase, I don't see a reason why
_sq_hamiltonian
exists, at least not as a class variable. We seem to only ever use it as an intermediate to construct a qubit hamiltonian. Why not just have the qubit hamiltonian as the class variable, and never save the SQ Hamiltonian?
This is a good point, it was previously used in QITE to inform the composition of the A operator, but that is now done with the SQOpPool. If a fermionic quantum computer is ever implemented (or if functions are written to apply SQOperators to a QuqntumComputer), then we may want to keep it. I'm not sure what best practice is in regard to preemptively writing code for future features.
from qforte.
The other point is that if we have non-JW transforms, the molecule knowing its Hamiltonian still makes sense. I think we'll be fine as long as we leave a comment.
I'll rip it out of QITE, then.
from qforte.
Question answered.
from qforte.
Related Issues (20)
- Auto-Documentation
- Build More Documentation
- Use Properties in Molecule
- Simplify System Factory
- Replace `_pool` with `_qubit_pool`
- Combine Amplitudes and Operator Pool HOT 1
- Remove `lib` HOT 1
- Synchronize `_pool_obj` and `_pool`
- Don't FCI by Default
- Frozen QPE HOT 2
- Function Renamings
- QKD Cleanup
- Decouple Reading From File from Molecule
- Generalize `_Uprep` HOT 1
- Optimization with Adam Optimizer
- Poor Installation Instruction HOT 1
- Autotests HOT 1
- Mysterious comment about external molecule building with point group symmetry
- difficult installation error
- Profile `gate`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from qforte.