Why does `sq_hamiltonian` exist? about qforte HOT 3 CLOSED

Looking over the codebase, I don't see a reason why _sq_hamiltonian exists, at least not as a class variable. We seem to only ever use it as an intermediate to construct a qubit hamiltonian. Why not just have the qubit hamiltonian as the class variable, and never save the SQ Hamiltonian?

This is a good point, it was previously used in QITE to inform the composition of the A operator, but that is now done with the SQOpPool. If a fermionic quantum computer is ever implemented (or if functions are written to apply SQOperators to a QuqntumComputer), then we may want to keep it. I'm not sure what best practice is in regard to preemptively writing code for future features.

from qforte.

The other point is that if we have non-JW transforms, the molecule knowing its Hamiltonian still makes sense. I think we'll be fine as long as we leave a comment.

I'll rip it out of QITE, then.

from qforte.

Question answered.

from qforte.