Giter VIP home page Giter VIP logo

Comments (7)

evanw avatar evanw commented on April 28, 2024

I don’t understand what you mean. Can you provide a small example JavaScript file and esbuild command line? What are you trying to accomplish?

from esbuild.

tmikaeld avatar tmikaeld commented on April 28, 2024

I'm trying to use it with Cloudflare Workers, which often have troubles if there's line-breaks in the source.

However, this time it was due to this issue:
#17 (comment)

Still, Webpack has an option to remove line-breaks, maybe we can have that in esbuild too?

Unrelated: Github still doesn't notify when commenting on a closed issue?

from esbuild.

evanw avatar evanw commented on April 28, 2024

Are you saying that Cloudflare Workers won’t run JavaScript files that are more than one line long? Are you trying to use esbuild’s minification to put everything on one line?

The minified code that esbuild generates currently has some newlines in it due to the way parallel compilation happens with source map concatenation, since source maps are line based. I can potentially see if there’s a way to remove those newlines if it’s an important feature.

from esbuild.

tmikaeld avatar tmikaeld commented on April 28, 2024

They normallt do, I'm not always sure why they don't and I didnt have time to spend days digging into webpack. So line breaks are not a priority, more like a nice add-on.

The export default is more important, I could get a bundled and minified script to work on Workers when I tried on a script that don't use export default.

from esbuild.

evanw avatar evanw commented on April 28, 2024

Can you give an example file (or files) where export default does not work as expected? That way I can reproduce and fix the issue.

from esbuild.

tmikaeld avatar tmikaeld commented on April 28, 2024

I'm unable to test it myself where I am right now, but here's some clues.

In a module:

export default async function something () {
   console.log('hello world');
}

And on import I had used conditionals:

const { default: something } = await import('./something');

Using conditional import is not very common, but handy when used in serverless context.

from esbuild.

tmikaeld avatar tmikaeld commented on April 28, 2024

By the way, I tried to get Cloudflare officially involved, but it didn't work ;-)

cloudflare/wrangler-legacy#1089

from esbuild.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.