Comments (4)
google-protobuf
released 3.21.2
, and I tested that it resolves the issue. So I think this can now be safely closed.
from eventstore-client-nodejs.
Hi Brice,
There seems to have been a breaking change in a patch version (or a broken release?) for google-protobuf
.
3.21.0
works
3.21.1
is broken
I'm going to have to investigate a bit more and open an issue over there.
For the time being, if you can lock google-protobuf
to the last working version:
yarn
:
"resolutions": {
"google-protobuf": "3.21.0"
}
npm
:
"overrides": {
"google-protobuf": "3.21.0"
}
from eventstore-client-nodejs.
Thank you bro this is perfect, and really short delay to answer. That is a really good point for eventstore.
I think you should lock package version, to prevent this kind of bug on the future.
I'm glad that was not happened on production. :)
from eventstore-client-nodejs.
I found an existing upstream issue here: protocolbuffers/protobuf-javascript#141
It seems like a lot of the methods were removed by an attempt to reduce the bundle size.
In the mean time, I'm going to reopen this issue and pin it until the upstream is fixed, as others are likely to have the same problem.
I think you should lock package version, to prevent this kind of bug on the future.
The problem with pinning dependencies in a library is that it causes duplication if two libraries depend on compatible versions, and we would have to release a new version of the library if a dependency had a bug fix or a vulnerability fix. (and everyone would have to update to that version of this lib to make use of that fix, possibly between major versions).
I'm glad that was not happened on production. :)
In an application, using a lock file to pin your entire dependency tree would prevent this from happening in production.
from eventstore-client-nodejs.
Related Issues (20)
- Is there a way how to force release all resources created by client? HOT 5
- Automatically close batch append connection
- Memory leak
- Memory leak HOT 4
- Wrong comment in readStream.d.ts HOT 1
- Memory Leak on readStream HOT 9
- Retrieving batch of events from catchup subscriptions HOT 3
- Feature Request: gRPC-web adapter. HOT 1
- Unable to Connect to Insecure Docker Compose HOT 5
- `emitEnabled` only available on projection update, not on create HOT 2
- Appending more than 100 events at once on a fresh connection fails. (Batch append?) HOT 1
- Add debug log if `serverFeatures` failed
- ServerFeatures should only assume unknown server on `UNIMPLEMENTED` error
- created is not a javascript safe integer HOT 2
- Gracefull shutdown HOT 1
- Trouble connecting to cloud cluster from AWS HOT 2
- Please ship a sourcemap HOT 2
- Trying to append an event with wrong id results in UnknownError HOT 1
- appendToStream with expectedRevision -1 causes cryptic error HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eventstore-client-nodejs.