readUint64String is not a function about eventstore-client-nodejs HOT 4 CLOSED

google-protobuf released 3.21.2, and I tested that it resolves the issue. So I think this can now be safely closed.

from eventstore-client-nodejs.

Hi Brice,

There seems to have been a breaking change in a patch version (or a broken release?) for google-protobuf.

3.21.0 works
3.21.1 is broken

I'm going to have to investigate a bit more and open an issue over there.

For the time being, if you can lock google-protobuf to the last working version:

yarn:

"resolutions": {
  "google-protobuf": "3.21.0"
}

npm:

"overrides": {
  "google-protobuf": "3.21.0"
}

from eventstore-client-nodejs.

Thank you bro this is perfect, and really short delay to answer. That is a really good point for eventstore.

I think you should lock package version, to prevent this kind of bug on the future.

I'm glad that was not happened on production. :)

from eventstore-client-nodejs.

I found an existing upstream issue here: protocolbuffers/protobuf-javascript#141

It seems like a lot of the methods were removed by an attempt to reduce the bundle size.

In the mean time, I'm going to reopen this issue and pin it until the upstream is fixed, as others are likely to have the same problem.

I think you should lock package version, to prevent this kind of bug on the future.

The problem with pinning dependencies in a library is that it causes duplication if two libraries depend on compatible versions, and we would have to release a new version of the library if a dependency had a bug fix or a vulnerability fix. (and everyone would have to update to that version of this lib to make use of that fix, possibly between major versions).

I'm glad that was not happened on production. :)

In an application, using a lock file to pin your entire dependency tree would prevent this from happening in production.

from eventstore-client-nodejs.