Giter VIP home page Giter VIP logo

Comments (6)

sudorandom avatar sudorandom commented on June 25, 2024

After doing a bit of research it looks like the packaged volumes are static per category of ship. Fuzzworks seems to have the packaged volumes here:
https://www.fuzzwork.co.uk/dump/latestyaml/

I will work on using this to display packaged volumes. I think packaged volumes makes sense for most items (that can be packaged) so I'll show that by default.

from go-evepraisal.

sudorandom avatar sudorandom commented on June 25, 2024

I released this just a bit ago. Packaged volumes will be used for items that are able to be packaged.

from go-evepraisal.

pedter avatar pedter commented on June 25, 2024

Just testing things out; I'm not really sure what's going on here in this one - http://evepraisal.com/a/bxj8u

The station container is properly 10k m3, but the capital module is 4k (they're typically 1k packaged). Additionally, the battleship is reporting 15k (as if it's a battlecruiser, perhaps?) instead of 50k. Last up, the total volume calculated at the bottom of the page appears to be using assembled volume values instead of packaged values; this might actually be intended but is rather confusing in its current state.

from go-evepraisal.

sudorandom avatar sudorandom commented on June 25, 2024

Hrm, I'm not sure. 15,000 is what fuzzworks has for every battleship type. I feel like that data might is incorrect

from go-evepraisal.

sudorandom avatar sudorandom commented on June 25, 2024

@pedter I just pushed a change which basically hard-codes the packaged volumes for different ship types. Thanks for double-checking me!

from go-evepraisal.

pedter avatar pedter commented on June 25, 2024

Fantastic, thanks! I've just now had time to test them all out and there are still a couple of exceptions that slipped through, unfortunately. I'll create a new issue once I've tracked them all down.

from go-evepraisal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.