Comments (2)
Currently we have same styles in theme and in block repos and this is super confusing. I have couple suggestions to solve this...
-
As the blocks are now decoupled from the theme it makes sense to have styles in the block repositories. Downside is that we can't really reuse any of the styles easily (this might not be an issue). You could end up creating classes with same names which can be annoying / hard to debug.
-
Keep the styles in theme. This doesn't make a lot of sense?
-
Keep the block specific styles for version control and prototyping but once working on a project copy the styles to /assets?
from swiss.
Completely agree this is an issue that needs to be addressed.
When originally decoupling Everblox to their own entities i left the CSS and JS to be unopinionated as i had no answer to that question and so left open to use styles directly in the block directory or the theme styles with the use of a helper import. The balance of maintainable CSS and reusable CSS gets a little blurry, messy and problematic when we have decoupled entities such as the theme and Everblox in different locations with common styles and utils needed across both.
I guess it would be to figure out how to identify maintainable CSS and reusable CSS. Maintainable CSS would make life easier but the CSS would get large and duplicate styles doing the same thing so has its up and downs. Reusable CSS becomes difficult when you need to define and access common styles and utils across the place, so the blocks kind of feel they would then have dependencies which gets messy to manage.
Maybe we could pick a visual from a recent design, to dissect and identify what is what in terms of maintainable CSS and reusable CSS and their entities? Then figure out how to bundle it?
from swiss.
Related Issues (19)
- Update to jQuery 3+ HOT 2
- Change share icons to Font Awesome 5 HOT 1
- How to handle themeing HOT 1
- CSS and JS don't work out the box
- Focal point cropping
- Remove manual DNS-prefetch from header.php
- get_the_tag_list returns empty when called in sidebar. Use get_tags instead.
- Add Lead Text etc. styles to TinyMCE format dropdown
- wysiwyg-html mixin surprisingly sets element position to relative HOT 1
- Only using PHP for all ACF field definitions (discussion)
- Site logo(s) should be adjustable from the backend HOT 2
- Imported Font Awesome 5 slows down compiling
- Unnecessary execute bits
- Separate clearfix to its own mixin
- Generalize the scheming
- Enable CSS outlines HOT 1
- Incorrect margin on section block if first
- Sidebar Tags widget uses incorrect function to get a list of tags
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swiss.