Giter VIP home page Giter VIP logo

Comments (2)

peksipatongeis avatar peksipatongeis commented on September 24, 2024

Currently we have same styles in theme and in block repos and this is super confusing. I have couple suggestions to solve this...

  1. As the blocks are now decoupled from the theme it makes sense to have styles in the block repositories. Downside is that we can't really reuse any of the styles easily (this might not be an issue). You could end up creating classes with same names which can be annoying / hard to debug.

  2. Keep the styles in theme. This doesn't make a lot of sense?

  3. Keep the block specific styles for version control and prototyping but once working on a project copy the styles to /assets?

from swiss.

onefastsnail avatar onefastsnail commented on September 24, 2024

Completely agree this is an issue that needs to be addressed.

When originally decoupling Everblox to their own entities i left the CSS and JS to be unopinionated as i had no answer to that question and so left open to use styles directly in the block directory or the theme styles with the use of a helper import. The balance of maintainable CSS and reusable CSS gets a little blurry, messy and problematic when we have decoupled entities such as the theme and Everblox in different locations with common styles and utils needed across both.

I guess it would be to figure out how to identify maintainable CSS and reusable CSS. Maintainable CSS would make life easier but the CSS would get large and duplicate styles doing the same thing so has its up and downs. Reusable CSS becomes difficult when you need to define and access common styles and utils across the place, so the blocks kind of feel they would then have dependencies which gets messy to manage.

Maybe we could pick a visual from a recent design, to dissect and identify what is what in terms of maintainable CSS and reusable CSS and their entities? Then figure out how to bundle it?

from swiss.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.