Giter VIP home page Giter VIP logo

Comments (21)

kunyan avatar kunyan commented on July 18, 2024 6

@vhpoet https://github.com/kunyan/koa-cors/tree/next

from koa-cors.

doliver3 avatar doliver3 commented on July 18, 2024 6

It would be great to get @kunyan's change published to npm as koa-cors@next. What is the next step?

from koa-cors.

leebenson avatar leebenson commented on July 18, 2024 5

@evert0n, could you push the new patch when you get a spare few mins please? @kunyan's instructions for loading @next are working well, but it'd be good to have an official NPM release.

from koa-cors.

zouxuoz avatar zouxuoz commented on July 18, 2024 5

Guys, you can use CORS from main organization https://github.com/koajs/cors.

from koa-cors.

evert0n avatar evert0n commented on July 18, 2024 4

I check it out this weekend guys, I will also catch up with the other issues too, Thank you

from koa-cors.

leebenson avatar leebenson commented on July 18, 2024 3

@evert0n - any update to this? thanks!

from koa-cors.

kunyan avatar kunyan commented on July 18, 2024 2

@evert0n can you checkout a new branch named "next". and I will create a PR to it.
then you can publish a new package to npm. the user could use npm install koa-cors@next to download it

I think this way will be better.

from koa-cors.

kunyan avatar kunyan commented on July 18, 2024 1

pls use this until @evert0n push new patch

"koa-cors": "git+https://[email protected]/kunyan/koa-cors.git#next",

from koa-cors.

vhpoet avatar vhpoet commented on July 18, 2024

@kunyan are you planning on making a PR?

from koa-cors.

kunyan avatar kunyan commented on July 18, 2024

@vhpoet I can't push a new branch to upstream :(

from koa-cors.

shellscape avatar shellscape commented on July 18, 2024

@kunyan can you publish this as a module, perhaps koa-cors-next ?

from koa-cors.

crunchtime-ali avatar crunchtime-ali commented on July 18, 2024

Just in time for the arrival of native async..await in Node v7.

from koa-cors.

shellscape avatar shellscape commented on July 18, 2024

exactly. one more thing we don't have to have babel transpile

from koa-cors.

csakbalint avatar csakbalint commented on July 18, 2024

@evert0n - hey, is there any possible update to this?

from koa-cors.

steffen avatar steffen commented on July 18, 2024

What's needed to get @kunyan's changes into an official release? Would be nice to get rid of the deprec warning. :) Thanks!

from koa-cors.

meaku avatar meaku commented on July 18, 2024

@kunyan @evert0n how about a pull request with @kunyan's changes?

from koa-cors.

jsonmaur avatar jsonmaur commented on July 18, 2024

Until this gets merged, you can use https://github.com/th507/koa-adapter to get rid of the deprecation warning.

from koa-cors.

amit777 avatar amit777 commented on July 18, 2024

hi @evert0n I was wondering if you were planning on merging the pull request from @kunyan. Thank you both for creating this!

from koa-cors.

bradleyayers avatar bradleyayers commented on July 18, 2024

Hi @evert0n would you be open to having someone else help maintain this library?

from koa-cors.

shellscape avatar shellscape commented on July 18, 2024

@bradleyayers why not just use the module maintained by the project? https://github.com/koajs/cors

from koa-cors.

amit777 avatar amit777 commented on July 18, 2024

@shellscape that's a great q.. I can't remember why I didn't personally use it, but I vaguely remember being some reason. I should probably take a second look at it. thanks for the tip.

from koa-cors.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.