Giter VIP home page Giter VIP logo

Comments (10)

evgenyneu avatar evgenyneu commented on June 8, 2024 1

Thanks, @tarek903, this needs to be done then.

from cosmos.

evgenyneu avatar evgenyneu commented on June 8, 2024 1

Cosmos now supports right-to-left languages from version 8.0. Thanks for your help @tarek903 and @farshadjahanmanesh. Please let me know if notice any issues.

from cosmos.

evgenyneu avatar evgenyneu commented on June 8, 2024 1

@nemexyz, thank you for reporting this. I have removed UIApplication.shared from the code and released version 8.0.2. Let me know if it still does not compile. The side effect of this, unfortunately, is that right-to-left only works for iOS 9+.

from cosmos.

evgenyneu avatar evgenyneu commented on June 8, 2024

Hello @tarek903, good question. The reason I have not implemented it yet is because the App Store does not switch the direction of the star rating control in Arabic:

Right-to-left language rating control in App Store

I am not a right-to-left language user, so I have a question. Is it normal to keep the direction the same for the stars as in English in right-to-left language countries? Or should the star control be flipped?

from cosmos.

tarek903 avatar tarek903 commented on June 8, 2024

yea the stars should be flipped
ex:
screen shot 2016-12-14 at 12 31 15 pm

from cosmos.

farshadjahanmanesh avatar farshadjahanmanesh commented on June 8, 2024

one approach is reversing everything, swap your empty color with fill color, and minus rank from max rank
rank is 3.5 --> 3 and half filled star and one and half empty star
==> 3.5 - 5 = 1.5 ---> one and half empty, 3 and half filled
when your swap empty and fill colors, cosmos looks like right to left 😄

from cosmos.

evgenyneu avatar evgenyneu commented on June 8, 2024

Hehe, clever hack!

from cosmos.

tarek903 avatar tarek903 commented on June 8, 2024

@farshadjahanmanesh Wow .. That actually works thanks

from cosmos.

nemexyz avatar nemexyz commented on June 8, 2024

Hello,

Update version 8.0.1 in my project, work with an application and a framework that generates error when building it by UIApplication.shared of the RightToLeft support. Can you support framework with API extension?

captura de pantalla 2017-01-25 a las 11 53 53 a m

Thanks...

from cosmos.

evgenyneu avatar evgenyneu commented on June 8, 2024

Closing, feel free to reopen when needed.

from cosmos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.