Comments (10)
Thanks, @tarek903, this needs to be done then.
from cosmos.
Cosmos now supports right-to-left languages from version 8.0
. Thanks for your help @tarek903 and @farshadjahanmanesh. Please let me know if notice any issues.
from cosmos.
@nemexyz, thank you for reporting this. I have removed UIApplication.shared
from the code and released version 8.0.2
. Let me know if it still does not compile. The side effect of this, unfortunately, is that right-to-left only works for iOS 9+.
from cosmos.
Hello @tarek903, good question. The reason I have not implemented it yet is because the App Store does not switch the direction of the star rating control in Arabic:
I am not a right-to-left language user, so I have a question. Is it normal to keep the direction the same for the stars as in English in right-to-left language countries? Or should the star control be flipped?
from cosmos.
yea the stars should be flipped
ex:
from cosmos.
one approach is reversing everything, swap your empty color with fill color, and minus rank from max rank
rank is 3.5 --> 3 and half filled star and one and half empty star
==> 3.5 - 5 = 1.5 ---> one and half empty, 3 and half filled
when your swap empty and fill colors, cosmos looks like right to left 😄
from cosmos.
Hehe, clever hack!
from cosmos.
@farshadjahanmanesh Wow .. That actually works thanks
from cosmos.
Hello,
Update version 8.0.1 in my project, work with an application and a framework that generates error when building it by UIApplication.shared of the RightToLeft support. Can you support framework with API extension?
Thanks...
from cosmos.
Closing, feel free to reopen when needed.
from cosmos.
Related Issues (20)
- Command CompileSwift failed with a nonzero exit code HOT 1
- Storyboard warning on Xcode 12.1: "Ignoring user defined runtime attribute for key path "updateOnTouch"" HOT 3
- Unwanted behavior in a UIScrollView HOT 4
- Please add macOS support in SwiftUI HOT 3
- How to disable tapping? HOT 2
- How to set empty image for empty start(non partially filled as well) HOT 6
- My image and `withTintColor` HOT 2
- How to prevent didTouchCosmos from issuing a rating
- Can you please build the framework for the Simulator HOT 3
- [Feature Request] Add custom image for half star HOT 4
- Filled color values changing even though the data is not. HOT 6
- Error While installing pod. HOT 1
- Tap gesture recognizer messes up Cosmos HOT 1
- Build failed in Storyboard
- Showing Recent Messages /Package.swift has no Package.swift manifest for version 9.0.0 in https://github.com/evgenyneu/Cosmos.git
- Single star doesn't show precise filling.
- Tapping on Rating always select 3 rating when VoiceOver is on
- Remove rating after giving
- Set custom accessibilityLabel for Cosmos View HOT 1
- demo
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cosmos.