Giter VIP home page Giter VIP logo

Comments (3)

smilingthax avatar smilingthax commented on May 20, 2024

When I encounter this Problem, the initial load DOM contains:

<h2 class="markdown" id="4">Some Section</h2>

but after HMR it's just:

<h2 class="markdown">Some Section</h2>

I.e. the idattribute is missing. Also, the right sidebar navigation (Sections on the Page) stops working (URL changes to include #4, but there's no such anchor position in the DOM any more).
I suppose this also causes the repositioning after HMR to fail.

from evidence.

archiewood avatar archiewood commented on May 20, 2024

Having looked at this problem recently (id generation and navigation), there are some issues with the way we add the Table of Contents.

The TOC and anchor links are generated client side (and not during prebuild)

I think the design reason for this is that in principle, user interaction could change what headings exist on the page (eg change the number of rows that are looped through, change the heading text etc.

This is suboptimal because it means that you cannot navigate from another site or page in an evidence project to an anchor link

from evidence.

smilingthax avatar smilingthax commented on May 20, 2024

I see... unfortunately, putting the MutationObserver on <article> will trigger it very often (e.g just by moving the mouse over a graph, tooltips are added to/removed from the dom), and although after HMR then the <h2> tags regained their id, this did not fix the jump-to-top problem in my short experiment...

from evidence.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.