Giter VIP home page Giter VIP logo

Comments (7)

mcrascal avatar mcrascal commented on September 6, 2024 1

@zachstence is this actually spurious - there should be 2 inputs set on that page?

I think until we have unit test coverage it'd be preferable to have this visibility.

from evidence.

ItsMeBrianD avatar ItsMeBrianD commented on September 6, 2024

@mcrascal if you can review this we can hand it off to @zachstence next week

from evidence.

zachstence avatar zachstence commented on September 6, 2024

Need to look into why these stories are blank
#2191 (comment)

@kwongz said he has to refresh a couple times to get these stories to show up locally
@ItsMeBrianD thinks it may be related to fetching a bunch of parquet for storybook

from evidence.

zachstence avatar zachstence commented on September 6, 2024

Regarding this diff here:
https://www.chromatic.com/test?appId=645d58d2e049d64800e0ee15&id=66a136e4a07200986623171f

The only thing that has changed is the "X inputs" accordion at the bottom. We should either remove this from the stories, or make it invisible during Chromatic snapshots.

We can leverage unit testing to make sure components are properly setting the input context

from evidence.

zachstence avatar zachstence commented on September 6, 2024

Found an open issue regarding Recharts struggling to use Chromatic for their testing
recharts/recharts#3855

from evidence.

zachstence avatar zachstence commented on September 6, 2024

Seems like the text is stretching/squishing by one pixel in the vertical direction...

2024-08-08.15-21-04.mov

from evidence.

zachstence avatar zachstence commented on September 6, 2024

Happening with a larger font size as well. Interestingly, the axis labels have the same issue, but this time in the reverse order compared to the reference line labels

2024-08-08.16-26-35.mov

from evidence.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.