Comments (4)
I suppose that's a side effect of always having the group leader being registered as ML :)
Eitherway, IsInInstance()
should fix that quite easily.
from rclootcouncil2.
I think add a line in GetML and NewMLCheck will do it, similar to if IsPartyLFG() then return end
I think GROUP_LEFT
will be fired when left pvp instance (not 100% sure, but when I left arena, there is system message "Your group has been disbanded", will check later), so things will perform normally after leaving pvp instance, even if the group is premade.
from rclootcouncil2.
if select(2, IsInInstance()) == "pvp" or select(2, IsInInstance()) == "arena" then return end
from rclootcouncil2.
Yup, did that yesterday, just forgot to push it 7a2d174.
PLAYER_ENTERING_WORLD
will at the very least be fired. One issue with this though, is it would create the popup whenever you leave pvp instead of entering, assuming one uses the "ask when leader" setting. I suppose doing the pvp check just before asking for usage will suffice. This way it'll keep any registered ML but just suppress any popups while pvping.
from rclootcouncil2.
Related Issues (20)
- RC group loot master looter inaccurate loot queue HOT 1
- Feature Request: Start Session as Council Member HOT 12
- Patch 10.0 BugSacks HOT 1
- /rc add all command (WotLK) HOT 13
- TOC Incorrect in 3.5.0 Release HOT 1
- Addon sometimes does not work correctly with no error HOT 4
- Option to "not use RCLC" does not work when entering raid HOT 2
- [BUG] HOT 3
- [BUG] LUA Error when the addon tries to pass (or hide) the Need/Greed window HOT 5
- [Feature] Require notes per response HOT 2
- [Feature] Mounts and bags button groups
- [BUG] Lua Error HOT 2
- [BUG] Unable to unvote sometimes as master looter HOT 2
- [Feature] Add ilvl to csv export
- Feature Request - Log rolls HOT 1
- [Feature] Add a notes section for why an item was awarded
- [BUG] Unable to sync settings when on different (but connected) realms HOT 3
- Autopass | Don't pass on transmoggable items HOT 1
- Rolls not visible after the 4th loot HOT 1
- [BUG] New Roll System Sorting Error HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rclootcouncil2.