Giter VIP home page Giter VIP logo

Comments (4)

evil-morfar avatar evil-morfar commented on July 16, 2024

I suppose that's a side effect of always having the group leader being registered as ML :)

Eitherway, IsInInstance() should fix that quite easily.

from rclootcouncil2.

SafeteeWoW avatar SafeteeWoW commented on July 16, 2024

I think add a line in GetML and NewMLCheck will do it, similar to if IsPartyLFG() then return end
I think GROUP_LEFT will be fired when left pvp instance (not 100% sure, but when I left arena, there is system message "Your group has been disbanded", will check later), so things will perform normally after leaving pvp instance, even if the group is premade.

from rclootcouncil2.

SafeteeWoW avatar SafeteeWoW commented on July 16, 2024

if select(2, IsInInstance()) == "pvp" or select(2, IsInInstance()) == "arena" then return end

from rclootcouncil2.

evil-morfar avatar evil-morfar commented on July 16, 2024

Yup, did that yesterday, just forgot to push it 7a2d174.

PLAYER_ENTERING_WORLD will at the very least be fired. One issue with this though, is it would create the popup whenever you leave pvp instead of entering, assuming one uses the "ask when leader" setting. I suppose doing the pvp check just before asking for usage will suffice. This way it'll keep any registered ML but just suppress any popups while pvping.

from rclootcouncil2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.