Comments (8)
Just hope Argus is dead this week, so I may help a bit. #134 is close to finish, and it is just untouched for a while. Adding some filters to #143 is not hard, and it is a nice feature to have.
#125 is a bit complicated, and I am not sure if it should be in v2.8. It could be a part of v3
from rclootcouncil2.
I've already started on #125 - I'm only missing the receiving part of it. The reason I want to do it now is a reconnect
command has the potential to fill the comms buffer thus delaying everything significantly. The only remaining question is which serializer to use, and if LibCompress should be used as well.
from rclootcouncil2.
Dont change the serialize or use LibCompress which breaks all compatibility.
The new serializer isn't ready yet, and I am planning to implement an optimization targeting specific to the item string.
Full compatibility break should come in the next expansion, or in the pre-patch, in the version3, when it's likely we will change the addon comm prefix from RCLootCouncil to sth else
from rclootcouncil2.
I wasn't planning on breaking any compatibility but the reconnect
. I considered using LibCompress just for that, however it would require it to use a separate comm system and prefix (or some ugly extra checks) - all in all probably not worth it for now.
from rclootcouncil2.
I dont think all these changes should be in v2.8. Many should be in v3.0, because I don't think RCLootCouncil is very important addon at the end of expansion. Since we're going to restructure RCLootCouncil in v3.0 anyway, it's better to implement some features there instead, for example, Optimize reconnect data #125. This will spend you lots of time to fix it in v2.8, but it should not be a problem in v3.0
from rclootcouncil2.
I have planned to implement pure LUA version of DEFLATE algorithm, which is used by zip. According to my tests, it takes ~200 bytes to transmit all equipped item strings if the data is compressed by zip. However, it will be long time if I manage to make it work and fast. Speed expectation: as fast as libcompress's CompressLZW+CompressHuffman
from rclootcouncil2.
I dont think all these changes should be in v2.8.
That's why I've mostly chosen those that's almost finished anyway. I'd very much like to get the PL stuff out now while especially many uses PL, to get a feel for how it's received. The rest is just optimizations, a lot of which is easily reuseable in later versions.
I don't think RCLootCouncil is very important addon at the end of expansion
While true, it's not the right mindset to have, and is no excuse for not doing any updates (a lot of people still use it). Besides, I'd rather do new features and get feedback now where any potential shortcomings doesn't matter too much, than finding out at the start of the next xpac that feature x breaks everything.
LUA version of DEFLATE algorithm
If you think it's worth it, then cool.
from rclootcouncil2.
2.8 is released, not all of the bullets made it into the release though. Closing this.
from rclootcouncil2.
Related Issues (20)
- [BUG] Unable to unvote sometimes as master looter HOT 2
- [Feature] Add ilvl to csv export
- Feature Request - Log rolls HOT 1
- [Feature] Add a notes section for why an item was awarded
- [BUG] Unable to sync settings when on different (but connected) realms HOT 3
- Autopass | Don't pass on transmoggable items HOT 1
- Rolls not visible after the 4th loot HOT 1
- [BUG] New Roll System Sorting Error HOT 1
- [BUG] Awarded and traded items are not recognized (Wotlk)
- [BUG] Enchanter sometimes isn't available to be selected from the Disenchant button HOT 1
- [Feature request] One click to assign item to be Disenchanted HOT 1
- [BUG] LUA Error: bad argument #1 to 'strfind' HOT 1
- [Feature] Autopass for weapons missing main stat HOT 3
- [BUG] Additional buttons for chest slot of Amirdrassil raid armor not wroking HOT 6
- [BUG] Issues after Amirdrassil cutscenes (following Smolderon, Tindral, Fyrakk). HOT 2
- Hidden window during looting[BUG] HOT 2
- [BUG] When you don't award all items, the listview for new items bug HOT 2
- [BUG] Error Lua with Neat Minimap HOT 2
- [BUG]Lua Error when looking at reputations HOT 1
- [BUG] Conflict with Craft Presence
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rclootcouncil2.