Comments (1)
Both suggestions could potentially cause an "unable to award" due to filled bags. With the first, player has 1 free space, and wins two items. With the second he could just ignore it, or maybe even just fail to clear his bags in time.
I don't really want to disable buttons due to full bags - it could take some time to clear out.
Doing some warning text is possible, but then why not just print something to chat?
Either way, I'd very much prefer to relay some information back to the ML. This could be done when awarding (like the current checks, except the candidate sends a "bags_full" comm so we know for certain), or simply just send it whenever our bags are full. I imagine the latter being more reliable, but way more costly. Edit: Probably not if it's only done when we receive a lootTable, and if an award fails, we almost know for sure his bags are full and can use that for the fail message, otherwise we just ignore it.
from rclootcouncil2.
Related Issues (20)
- [BUG] Unable to unvote sometimes as master looter HOT 2
- [Feature] Add ilvl to csv export
- Feature Request - Log rolls HOT 1
- [Feature] Add a notes section for why an item was awarded
- [BUG] Unable to sync settings when on different (but connected) realms HOT 3
- Autopass | Don't pass on transmoggable items HOT 1
- Rolls not visible after the 4th loot HOT 1
- [BUG] New Roll System Sorting Error HOT 1
- [BUG] Awarded and traded items are not recognized (Wotlk)
- [BUG] Enchanter sometimes isn't available to be selected from the Disenchant button HOT 1
- [Feature request] One click to assign item to be Disenchanted HOT 1
- [BUG] LUA Error: bad argument #1 to 'strfind' HOT 1
- [Feature] Autopass for weapons missing main stat HOT 3
- [BUG] Additional buttons for chest slot of Amirdrassil raid armor not wroking HOT 6
- [BUG] Issues after Amirdrassil cutscenes (following Smolderon, Tindral, Fyrakk). HOT 2
- Hidden window during looting[BUG] HOT 2
- [BUG] When you don't award all items, the listview for new items bug HOT 2
- [BUG] Error Lua with Neat Minimap HOT 2
- [BUG]Lua Error when looking at reputations HOT 1
- [BUG] Conflict with Craft Presence
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rclootcouncil2.