Giter VIP home page Giter VIP logo

Comments (4)

nepalez avatar nepalez commented on August 16, 2024

@palkan Could you look at
https://github.com/evilmartians/evil-client/blob/1.1.0/spec/unit/rspec/stub_evil_client_operation_spec.rb
https://github.com/evilmartians/evil-client/blob/1.1.0/spec/unit/rspec/expect_evil_client_operation_spec.rb

from evil-client.

palkan avatar palkan commented on August 16, 2024

👍 LGTM

One comment: what about make shorter names and remove "evil", 'cause users will use it to test Some::Client – nothing about evil-client itself.
So, just: stub_client_operation and expect_client_operation – these names look descriptive and unique enough (I've tried to search on GitHub and found nothing).

from evil-client.

nepalez avatar nepalez commented on August 16, 2024

Well, at first I were thinking of stub_operation etc., then added evil_client just to prevent collisions.

You're right, _client_ should be enough

from evil-client.

nepalez avatar nepalez commented on August 16, 2024

Thank you! This will be included to v1.1.0

from evil-client.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.