Giter VIP home page Giter VIP logo

Comments (5)

Arkweid avatar Arkweid commented on August 19, 2024

Thank you for issue @piotrb!
Unfortunately, I'm a little busy in the coming days :(
If you have the opportunity to do PR with a correction, this will be great. I will accept it and release with your fix.

from lefthook.

Lighttree avatar Lighttree commented on August 19, 2024

Hi I have one issue with my project structure.
And I'm not sure is it in scope of this enhancement or not.

I'm trying to migrate JavaScript project from Husky. It has following folder structure:

/ my_project_parent
  / .git
  / my_project
       lefthook.yml
       package.json
       ...
...

The problem is that lefthook looking for .git folder in my_project at the moment, while it is actually in parent folder.

It would be nice if it can find parent .git and write hooks there.

from lefthook.

Arkweid avatar Arkweid commented on August 19, 2024

Yea, just need to replace calls form getRootDir() to result of that call: git rev-parse --show-toplevel.
In that case GIR_DIR env variable should be supported too.

from lefthook.

lisovskyvlad avatar lisovskyvlad commented on August 19, 2024

Would be awesome as next feature!

from lefthook.

Arkweid avatar Arkweid commented on August 19, 2024

Released in 0.7.0
More info here:
#72

from lefthook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.