Giter VIP home page Giter VIP logo

Comments (8)

pospielov avatar pospielov commented on May 11, 2024 1

Hi @shreyanshrs44, thanks for the interest in our repository, I assigned the issue to you

from compreface.

pranatimittal avatar pranatimittal commented on May 11, 2024

Hey, I would like to work on it. What exactly is expected from Detection and Verification services?

from compreface.

pospielov avatar pospielov commented on May 11, 2024

All the logic of the services already exists. All you need to do is to add a migration, so these services will be available from the first start of the application.
So what should you do:

  1. Create a changelog file, similar to the ones that in this folder:
    https://github.com/exadel-inc/CompreFace/tree/master/java/admin/src/main/resources/db/changelog
  2. Look at this migration:
    https://github.com/exadel-inc/CompreFace/blob/master/java/admin/src/main/resources/db/changelog/db.changelog-0.1.2.yaml#L25
    In lines 25-43 we are adding Face Recognition service. So basically your migration should be very similar.
  3. The only difference is that there is a new type field, so you need to add one more field in migration.
    Here is the available types:
    RECOGNITION("R"),
    DETECTION("D"),
    VERIFY("V");
    So the value for detection service will be:
  • column:
    name: type
    value: D
  1. Add your migration to this file:
    https://github.com/exadel-inc/CompreFace/blob/master/java/admin/src/main/resources/db/changelog/db.changelog-master.yaml

from compreface.

pranatimittal avatar pranatimittal commented on May 11, 2024

and table would be user only right?

from compreface.

pospielov avatar pospielov commented on May 11, 2024

The table is model

from compreface.

pospielov avatar pospielov commented on May 11, 2024

Hi @pranatimittal, just wanted to know if you have any issues with the completion of this task.
If you don't want to work on it anymore, please notify me, so I'll assign it to other contributors.

from compreface.

shreyanshrs44 avatar shreyanshrs44 commented on May 11, 2024

@pospielov The change looks straightforward to me. Although the learning point here is how we handle db migrations, I have never came across LiquiBase, but as I read about it it really excites me, learned something new today.
Thanks for putting out the issue !
If this not worked on anymore I would happily raise a PR

from compreface.

pospielov avatar pospielov commented on May 11, 2024

Thanks for the contribution

from compreface.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.