Project structure about excalidraw HOT 13 CLOSED

Jest is already installed in the project (via react-scripts package)

from excalidraw.

IMO we should migrate to functional react, i dont see any benefit is us having this in classes. Maybe @vjeux could clarify if we have any technical blocker to migrate this to hooks.
I also think we should add eslint, it would help us alot when this project grows.
(In case we decide to add eslint) - We could also add a pre-commit hook using husky to lint and prettify the code before commiting.

from excalidraw.

@giovannigiordano you were right, so far it seems we could make it work. #63

from excalidraw.

What's the latest on npm vs yarn? I thought we started with yarn.

So, have we settled on npm, and should we install everything via npm so that we keep package-lock up to date?

(too bad npm takes 10x to install anything)

from excalidraw.

I started with hooks but couldn’t figure out how to read up to date variables when using addEventListener for window mousemove. If you can make it work that’d be awesome :)

457800c

from excalidraw.

I’d be happy with eslint, prettier, typescript and jest

from excalidraw.

1. For the hooks part, we could use then when we will split the application in more components, without forcing to use them.
2. Jest is ok. Maybe we can do some integration testing with Cypress to ensure everything is ok with interactivity?

from excalidraw.

ad 2: Cypress won't help here until they implement non-synthetic, native events (at least as far as interacting with the canvas is concerned). We could go with Puppeteer & CDP, or something like Selenium & WebDriver.

from excalidraw.

@dwelle with cypress you can interact with canvas using mouse events and maybe compare the result as a screenshot.

from excalidraw.

@giovannigiordano I thought we'd need to fire proper events. I'll investigate if we can emulate the tests in Cypress by triggering mouse events programmatically.

from excalidraw.

@dwelle I introduced yarn and then npm to use it in the deploy action, to avoid the usage of a custom action which integrates yarn (the nodejs action has npm).
The project is small, we don't have too many dependencies, so let's focus on other features.

from excalidraw.

Would you guys be interested in splitting the code into multiple files? I believe that it will improve dev workflow as it is easier to navigate through smaller files instead one large file.

from excalidraw.

I feel like we've done the original scope of this issue.

from excalidraw.